Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SonarQube Scanner demo #2181

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dzmitry-rudnouski
Copy link

Your checklist for this pull request

馃毃 Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or in Jenkins JIRA
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Did you provide a test-case? That demonstrates feature works or fixes the issue.

@dzmitry-rudnouski dzmitry-rudnouski requested a review from a team as a code owner December 9, 2022 10:14
@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #2181 (d512336) into master (884272e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2181   +/-   ##
=========================================
  Coverage     80.96%   80.96%           
  Complexity      843      843           
=========================================
  Files            72       72           
  Lines          2506     2506           
  Branches        352      352           
=========================================
  Hits           2029     2029           
  Misses          365      365           
  Partials        112      112           

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about adding this to the existing sonar demo?

https://github.com/jenkinsci/configuration-as-code-plugin/tree/master/demos/sonarqube

Please follow the contributing guide and add a test for this:
https://github.com/jenkinsci/configuration-as-code-plugin/blob/master/demos/README.adoc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants