Removed 4 unnecessary stubbings in RoundhouseActionTest.java #224
Conversation
| import hudson.model.Run; | ||
| import junit.framework.TestCase; | ||
|
|
||
| public class SecondRoundhouseActionTest extends TestCase { |
There was a problem hiding this comment.
Please use JUnit 4 rather than JUnit 3 for the tests. JUnit 4 is more familiar to Jenkins developers and is widely used in Jenkins plugins. See the stackoverflow article for more details on why JUnit 4 annotations are better than JUnit 3 inheritance.
Note that this suggestion won't compile if you apply it directly.
| public class SecondRoundhouseActionTest extends TestCase { | |
| public class SecondRoundhouseActionTest { |
| import hudson.model.Run; | ||
| import junit.framework.TestCase; | ||
|
|
||
| public class ThirdRoundhouseActionTest extends TestCase { |
There was a problem hiding this comment.
Please use JUnit 4 rather than JUnit 3 for the tests. JUnit 4 is more familiar to Jenkins developers and is widely used in Jenkins plugins. See the stackoverflow article for more details on why JUnit 4 annotations are better than JUnit 3 inheritance.
Note that this suggestion won't compile if applied directly. Switching to JUnit 4 requires more than this single change.
| public class ThirdRoundhouseActionTest extends TestCase { | |
| public class ThirdRoundhouseActionTest { |
Testing done
Submitter checklist
In our analysis of the project, we observed that
1 unnecessary stubbing which stubbed
getResultmethod inRoundhouseActionTest.setUpis created but is never executed by the testRoundhouseActionTest.testGetProjectActionsFromLastProjectBuild;4 unnecessary stubbings
RoundhouseActionTest.setUpare created but are never executed by 2 testsRoundhouseActionTest.testAccessors,RoundhouseActionTest.testGetProjectActions;3 unnecessary stubbings which stubbed
getParentmethod,getLastCompletedBuildmethod,getActionsmethod inRoundhouseActionTest.setUpare created but never executed by the testsRoundhouseActionTest.testGetStyleFromRunResult.Unnecessary stubbings are stubbed method calls that were never realized during test execution. Mockito recommends to remove unnecessary stubbings (https://www.javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/exceptions/misusing/UnnecessaryStubbingException.html).
We propose below a solution to remove the unnecessary stubbings.