Build param definitions #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the ability to fetch the Description and URL of a view, if the…
…ropriate hudson class will always yield appropriate parameters
| // Parameters may not always be the first definition. Search for 'hudson.model.ParametersAction' to find | ||
| // real parameters. | ||
| foreach ($this->build->actions as $action) { | ||
| if (isset($action->_class) && $action->_class === 'hudson.model.ParametersAction') { |
There was a problem hiding this comment.
Why do you need this condition ? With this one, I can't retrieve any parameters from my build (on jenkins 1.656)
There was a problem hiding this comment.
I know we don't have tools to automatically check code style, but can you replace your tabs by 4 spaces as we follow psr2/3 (cf https://github.com/jenkins-khan/jenkins-php-api#coding-standards)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build parameters are not always the first entry. Scanning for the appropriate hudson class will always yield appropriate parameters.