Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove windows-32 ffmpeg download #376

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

richardsondev
Copy link

Issue

When os.arch() == ia32 we try to download windows-32 ffmpeg but on ffbinaries it no longer exists: https://ffbinaries.com/api/v1/version/latest

From investigation, this is by design on their end and they will not provide 32-bit Windows binaries anymore.

On the Windows 11 x64 machine I am building on, os.arch() is returning ia32 and os.platform() returns win32 which is leading to ffmpeg to not automatically download as it attempts to download the windows-32 binary.

os.arch() and os.platform() from console.log:
image

But this is a 64-bit machine:
image

This change

This PR is removing windows-32 ffmpeg downloading since the link doesn't exist anymore. On my local Windows 11 x64 machine, it is now successfully downloading ffmpeg automatically from windows-64.

We could also find a new source for 32-bit Windows ffmpeg but from my investigation, the usage of 32-bit Windows is low.
At least on Steam, 32-bit Windows is only 0.18% of Windows machines: https://store.steampowered.com/hwsurvey/

0.18% = (0.12+0.05)*100/96.68

Tests

image

@richardsondev richardsondev changed the title Remove windows-32 ffmpeg download Remove windows-32 ffmpeg download Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant