Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit maximum FLAC audio channels in video to 2 on webOS #5452

Merged
merged 2 commits into from
May 21, 2024
Merged

Limit maximum FLAC audio channels in video to 2 on webOS #5452

merged 2 commits into from
May 21, 2024

Conversation

dmitrylyzo
Copy link
Contributor

@dmitrylyzo dmitrylyzo commented May 5, 2024 •
edited

webOS doesn't seem to support FLAC with more than 2 channels in video.

Changes

  • Limit maximum FLAC channels to 2 on webOS.
  • Split each video transcoding profile with FLAC so that the containing FLAC is only applied to 2 channels audio.

Issues
Fixes jellyfin/jellyfin-webos#146

@dmitrylyzo dmitrylyzo added bug Something isn't working p: webos This PR or issue mainly concerns WebOS clients playback This PR or issue mainly concerns playback labels May 5, 2024
@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit 26ff1ff
Status ✅ Deployed!
Preview URL https://789e4c3c.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs
View bot logs

@ilmc888
Copy link

ilmc888 commented May 13, 2024

Great, thanks. Now that 10.9 is out, I can test this later this week if needed.

@ilmc888
Copy link

ilmc888 commented May 14, 2024

A quick test seems to show that FLAC 7.1 is transcoded to FLAC. I think it is properly downmixed to 2.0 now, but the expected behavior is to transcode to 5.1/7.1 AAC (channels having priority over the format).

@dmitrylyzo
Copy link
Contributor Author

A quick test seems to show that FLAC 7.1 is transcoded to FLAC. I think it is properly downmixed to 2.0 now, but the expected behavior is to transcode to 5.1/7.1 AAC (channels having priority over the format).

Yeah, that would be preferable.
I guess, the server is selecting FLAC to FLAC, just ignoring the max channels. And then it applies the limit.

We need to make changes to the server so that it tries not to change the number of channels (maybe not only).

@jellyfin-bot

This comment has been minimized.

Sign in to view
@jellyfin-bot jellyfin-bot added the merge conflict Conflicts prevent merging label May 15, 2024
@dmitrylyzo dmitrylyzo changed the base branch from master to release-10.9.z May 15, 2024 13:40
@dmitrylyzo
Copy link
Contributor Author

Now I'm using ApplyConditions so that the video transcoding profile with FLAC is only applied to 2-channel audio.

@jellyfin-bot jellyfin-bot removed the merge conflict Conflicts prevent merging label May 16, 2024
@ilmc888
Copy link

ilmc888 commented May 17, 2024

I can confirm that video with FLAC 7.1 is now transcoded to multichannel AAC and FLAC 2.0 is played directly (at least for music, I don't have video with FLAC 2.0).

The FLAC 5.1 test file (surround5.1.flac) doesn't play correctly as a music file. Only left and right front channels are heard.

In any case, this PR solves the problem I was having with video + FLAC.

@dmitrylyzo
Limit maximum FLAC channels to 2 on webOS
1342bed
@dmitrylyzo
Add specialized video transcoding profile with FLAC for webOS
fb87dfb 
webOS doesn't seem to support FLAC with more than 2 channels.
Split each video transcoding profile with FLAC so that the
containing FLAC is only applied to 2 channels audio.
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@dmitrylyzo dmitrylyzo marked this pull request as ready for review May 21, 2024 20:24
@dmitrylyzo dmitrylyzo requested a review from a team as a code owner May 21, 2024 20:24
@dmitrylyzo
Copy link
Contributor Author

Since there are some uncertainties with FLAC as music, let's leave it as is and at least fix the video.

@dmitrylyzo dmitrylyzo added this to the v10.9.3 milestone May 21, 2024
@dmitrylyzo dmitrylyzo added this to In progress in Release 10.9.z via automation May 21, 2024
@dmitrylyzo dmitrylyzo changed the title Limit maximum FLAC channels to 2 on webOS Limit maximum FLAC audio channels in video to 2 on webOS May 21, 2024
@thornbill thornbill added the stable backport Backport into the next stable release label May 21, 2024
@thornbill thornbill merged commit 9d9b69e into jellyfin:release-10.9.z May 21, 2024
12 checks passed
Release 10.9.z automation moved this from In progress to Done May 21, 2024
@dmitrylyzo dmitrylyzo deleted the webos-flac-2ch branch May 21, 2024 20:37
@FintasticMan FintasticMan mentioned this pull request May 22, 2024
Open
joshuaboniface pushed a commit that referenced this pull request May 25, 2024
@dmitrylyzo @joshuaboniface
Backport pull request #5452 from jellyfin-web/release-10.9.z
6e32ea0 
Limit maximum FLAC audio channels in video to 2 on webOS

Original-merge: 9d9b69e

Merged-by: thornbill <thornbill@users.noreply.github.com>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
@jellyfin-bot jellyfin-bot removed the stable backport Backport into the next stable release label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
bug Something isn't working p: webos This PR or issue mainly concerns WebOS clients playback This PR or issue mainly concerns playback
Projects
Release 10.9.z
  
Done
Milestone
v10.9.3
Development

Successfully merging this pull request may close these issues.

Client tries to direct play FLAC 2.1 audio track, which results in no audio output
4 participants
@dmitrylyzo @jellyfin-bot @ilmc888 @thornbill