Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type annotations and mypy #821

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

oddstr13
Copy link
Member

@oddstr13 oddstr13 commented Feb 8, 2024

No description provided.

Copy link

sonarcloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues

Measures
0 Security Hotspots
No data about Coverage
2.2% Duplication on New Code

See analysis details on SonarCloud

@oddstr13 oddstr13 changed the title Pr-annotations-1 Type annotations and mypy Feb 8, 2024
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (bdebed0) 21.51% compared to head (49f6546) 21.80%.
Report is 9 commits behind head on master.

Files Patch % Lines
jellyfin_kodi/entrypoint/service.py 18.18% 9 Missing ⚠️
jellyfin_kodi/library.py 50.00% 8 Missing ⚠️
jellyfin_kodi/monitor.py 22.22% 7 Missing ⚠️
jellyfin_kodi/connect.py 25.00% 6 Missing ⚠️
jellyfin_kodi/helper/utils.py 50.00% 4 Missing ⚠️
jellyfin_kodi/views.py 0.00% 3 Missing ⚠️
jellyfin_kodi/client.py 33.33% 2 Missing ⚠️
jellyfin_kodi/dialogs/context.py 60.00% 2 Missing ⚠️
jellyfin_kodi/entrypoint/default.py 0.00% 2 Missing ⚠️
jellyfin_kodi/helper/wrapper.py 0.00% 2 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #821      +/-   ##
==========================================
+ Coverage   21.51%   21.80%   +0.29%     
==========================================
  Files          63       63              
  Lines        8542     8570      +28     
  Branches     1572     1574       +2     
==========================================
+ Hits         1838     1869      +31     
+ Misses       6680     6675       -5     
- Partials       24       26       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant