Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to force transcode Dobly Vision #807

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fezster
Copy link
Contributor

@fezster fezster commented Jan 9, 2024

Added setting to allow force transcode of Dolby Vision files.

This PR includes the hdr metadata fix.

On Firestick 4k Max, it is useful to be able to force a transcode with tone mapping for Dolby Vision files, otherwise certain profiles / combination of profiles just show a blank screen. I've had to force a transcode to h264 to achieve this.

Fix indentation error

Update actions.py

Update api.py
Added setting to allow force transcode of Dolby Vision files.

This PR includes the hdr metadata fix.
Copy link

sonarcloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@oddstr13 oddstr13 changed the title Setting force dolbyvision transcode Add setting to force transcode Dobly Vision Feb 3, 2024
@oddstr13 oddstr13 added the enhancement New feature or request label Feb 6, 2024
@mcarlton00
Copy link
Member

I haven't had a chance to look through everything closely, but the main issue I see is that you shouldn't be modifying all of the language files. That's going to break our translation service. You should only edit the english files, and the other languages will be updated automatically as translations come in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants