adjusted the pom so that the project: a) compiles with maven, b) compiles with Java8 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 10, 2016 21:31
weakened Javadoc checker: Java8's javadoc throws erros otherwise
… whole file changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I just checked out the examples and found, that they were not compiling as they referenced classes that were only presnt in the encog-core 3.4.0-SNAPSHOTS artifacts.
When I built and installed encog-core 3.4.0-SNAPSHOTS artifacts, the javadoc creation failed as java 8 is more strict in parsing as it was in Java 7 ( http://www.locked.de/2015/04/05/how-to-ignore-maven-javadoc-errors-in-java-8/ ). So - in order to just compile and use the code - I also added the param to not check for such errors (yes, the correct way would be to correct all javadocs - but please forgive me that I chose the easy path as I just wanted to get the code up and runngin ;-)).
Well - Maybe someone else runs into the same problems, so I thought to just give back the changes.
Hoping to get merged.
Cheers and thanks for the great lib!