Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significantly overhaul the ApnsClientMetricsListener interface #1046

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jchambers
Copy link
Owner

This (in my opinion) greatly improves the ApnsClientMetricsListener interface at the cost of making a bunch of breaking changes. The key changes are:

  1. We no longer issue opaque "notification IDs" to metrics listeners, but instead provide "send notification" durations where appropriate
  2. We now consolidate accepted/rejected handlers into a single "acknowledged" handler that has access to the full notification response
  3. The Micrometer implementation is now much, much more sensibly constructed; when I first built it, I had never really used Micrometer before and was mostly guessing at how it worked. Now that I have significant direct experience with it, I can offer a much more sensible and ergonomic design.

Feedback on all of this is very welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant