Skip to content

Commit

Permalink
Remove streams
Browse files Browse the repository at this point in the history
  • Loading branch information
jbmusso committed May 16, 2017
1 parent b46977a commit cfedb56
Show file tree
Hide file tree
Showing 8 changed files with 0 additions and 172 deletions.
2 changes: 0 additions & 2 deletions package.json
Expand Up @@ -35,10 +35,8 @@
"homepage": "https://github.com/jbmusso/gremlin-javascript",
"dependencies": {
"gremlin-template-string": "^2.0.0",
"highland": "^2.5.1",
"lodash": "^3.10.1",
"node-uuid": "^1.4.3",
"readable-stream": "^2.0.2",
"rx": "^4.1.0",
"ws": "^2.3.1"
},
Expand Down
5 changes: 0 additions & 5 deletions src/GremlinClient.js
Expand Up @@ -4,10 +4,8 @@ import { EventEmitter } from 'events';

import uuid from 'node-uuid';
import _ from 'lodash';
import highland from 'highland';

import WebSocketGremlinConnection from './WebSocketGremlinConnection';
import MessageStream from './MessageStream';
import * as Utils from './utils';

import Rx from 'rx';
Expand Down Expand Up @@ -216,9 +214,6 @@ class GremlinClient extends EventEmitter {
* Asynchronously send a script to Gremlin Server for execution and fire
* the provided callback when all results have been fetched.
*
* This method internally uses a stream to handle the potential concatenation
* of results.
*
* Callback signature: (Error, Array<result>)
*
* @public
Expand Down
14 changes: 0 additions & 14 deletions src/MessageStream.js

This file was deleted.

30 changes: 0 additions & 30 deletions src/executeHandler.js

This file was deleted.

13 changes: 0 additions & 13 deletions test/bindings.js
Expand Up @@ -13,19 +13,6 @@ describe('Bindings', function() {
});
});

it.skip('should support bindings with client.stream()', function(done) {
var client = gremlin.createClient();
var stream = client.stream('g.V(x)', { x: 1 });

stream.on('data', function(result) {
result.id.should.equal(1);
});

stream.on('end', function() {
done();
});
});

it.skip('should give an error with reserved binding name in .exec', function(done) {
var client = gremlin.createClient();

Expand Down
18 changes: 0 additions & 18 deletions test/createClient.js
Expand Up @@ -56,24 +56,6 @@ describe('.createClient()', function() {
client.options.aliases.should.eql({ h: 'g' });
});

it.skip('should override a set `processor` option on a per request basis', function(done) {
var client = gremlin.createClient({ op: 'foo' });

client.port.should.equal(8182);
client.host.should.equal('localhost');
client.options.op.should.equal('foo');

var s = client.stream('g.V(1)', null, { op: 'eval' });

s.on('data', function(result) {
result.should.be.an('object');
});

s.on('end', function() {
done();
});
});

describe('WebSocket path', () => {
it('should support a custom websocket path', () => {
const client = gremlin.createClient({ path: '/foo/bar' });
Expand Down
19 changes: 0 additions & 19 deletions test/messageStream.js

This file was deleted.

71 changes: 0 additions & 71 deletions test/stream.js

This file was deleted.

0 comments on commit cfedb56

Please sign in to comment.