Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python 3.6 support. #718

Merged
merged 2 commits into from
Apr 27, 2024

Conversation

jamaalscarlett
Copy link
Member

No description provided.

@guspix
Copy link
Contributor

guspix commented Apr 27, 2024

Looks good to me! Only tiny thing I can see is that the test_admin file has an if statement checking if the Python version is >= 3.7 which I guess would now be innecesary, but I don't think it really matters. This is my first time contributing so I'm not sure how this works, should I submit a review approving the code changes?

@jamaalscarlett
Copy link
Member Author

Looks good to me! Only tiny thing I can see is that the test_admin file has an if statement checking if the Python version is >= 3.7 which I guess would now be innecesary, but I don't think it really matters. This is my first time contributing so I'm not sure how this works, should I submit a review approving the code changes?

Yes please, once you approve it. I will merge it. Then you can rebase your pr to fix the failing 3.6 test. Then I will cut a release. Thanks again!

Copy link
Member

@50-Course 50-Course left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jamaalscarlet,

thank you for making this patch. Looking at @guspix comment and the updated change int the test,

# 3.6 adds a `,` to the string representation of the exception
python_version = sys.version_info[:2]
if python_version >= (3, 7):
    error_message = "Some messages could not be processed: UnregisteredError('error')"

With that, I must say this looks good to me.

@jamaalscarlett
Copy link
Member Author

@guspix @50-Course

Copy link

codecov bot commented Apr 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.39%. Comparing base (9bf5fda) to head (b85b162).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #718      +/-   ##
==========================================
+ Coverage   70.28%   70.39%   +0.10%     
==========================================
  Files          26       27       +1     
  Lines        1097     1101       +4     
  Branches      249      180      -69     
==========================================
+ Hits          771      775       +4     
  Misses        288      288              
  Partials       38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamaalscarlett jamaalscarlett merged commit 44977b1 into jazzband:master Apr 27, 2024
5 of 6 checks passed
@jamaalscarlett jamaalscarlett deleted the drop_py36_support branch April 27, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants