Add printscreen as a special key mapping for 44 #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add printscreen as a special key mapping for 44
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
=======================================
Coverage 90.52% 90.52%
=======================================
Files 1 1
Lines 211 211
=======================================
Hits 191 191
Misses 20 20 Continue to review full report at Codecov.
|
|
@ifdion It is not a standard key code? macOS
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode |
||||||||||||||||||||||||||
|
@jaywcjlove You're right. Should we check the the value on the user agent as you did on |
|
@ifdion I wonder if there is a better way to achieve it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add printscreen as a special key mapping for 44