Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Pilmoji.text function to add support of align and anchor #35

Merged
merged 1 commit into from
May 23, 2024

Conversation

madifaya
Copy link
Contributor

Hello !

I propose a solution to implement the parameters "anchor" and "align" into Pilmoji.text.

this should be linked to Issues :

@zsilverzweig
Copy link

👍

@madifaya
Copy link
Contributor Author

madifaya commented Feb 6, 2024

@jay3332

@LevaniVashadze
Copy link

@jay3332 could this be merged?

@madifaya
Copy link
Contributor Author

madifaya commented May 7, 2024

maybe @vertyco, @owocado , @annihilatorrrr or @WitherredAway can merge too ?

@WitherredAway
Copy link
Contributor

maybe @vertyco, @owocado , @annihilatorrrr or @WitherredAway can merge too ?

I'm not a maintainer

@annihilatorrrr
Copy link
Contributor

maybe @vertyco, @owocado , @annihilatorrrr or @WitherredAway can merge too ?

I'm not a maintainer.

@LevaniVashadze
Copy link

pip install git+https://github.com/madifaya/pilmoji.git@add-support-text-align
Until then this works, but merging would be really useful

@jay3332 jay3332 merged commit 005a8b6 into jay3332:2.0 May 23, 2024
@LevaniVashadze
Copy link

@madifaya Hey I noticed that this change is breaking the spacing between lines when changing it and also it messes up the emojis position when not changing the spacing, for example if the multiline text is: Hello\ntest😉 it breaks the emojis position only if the line doesn't contain a full height character.

@madifaya
Copy link
Contributor Author

@madifaya Hey I noticed that this change is breaking the spacing between lines when changing it and also it messes up the emojis position when not changing the spacing, for example if the multiline text is: Hello\ntest😉 it breaks the emojis position only if the line doesn't contain a full height character.

I didn't understand what breaks sorry. could you send a picture of the break and/or maybe the implementation that breaks please?

@LevaniVashadze
Copy link

@madifaya Hey I noticed that this change is breaking the spacing between lines when changing it and also it messes up the emojis position when not changing the spacing, for example if the multiline text is: Hello\ntest😉 it breaks the emojis position only if the line doesn't contain a full height character.

I didn't understand what breaks sorry. could you send a picture of the break and/or maybe the implementation that breaks please?

Hey the emojis are misaligned, i tried it with apple emojis and they were misaligned in your version(they were too low)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants