Adds inclusion and exclusion validators. #434
Conversation
|
@lhook, I read and re-read the tests, and sorry I do not understand what these validators do. Can you please explain? Also, add proper JavaDoc with real world examples, if possible? Code looks clean thouth. |
| public class AttributeExclusionValidatorTest extends ActiveJDBCTest { | ||
|
|
||
| @Test | ||
| public void testWhenAttributeIsExcluded() { |
There was a problem hiding this comment.
Also, we have switched to "should" prefix in all tests a few years ago. Here is one example:
https://github.com/javalite/activejdbc/blob/master/activejdbc/src/test/java/org/javalite/activejdbc/BelongsToParentsTest.java#L25
As you can see, the method name starts with "should" as opposed to "test". The "should" is more expressive than "test" and also indicates that the method name is an expectation.
Please, see more on this here: http://javalite.io/jspec
This is only recommendation :)
LewisHook
force-pushed
the
inclusion_and_exclusion_validators
branch
from
aafa10f
to
9ca3c69
Compare
|
Hi @ipolevoy, I hope this makes things a bit clearer. |
|
@lhook I will review later and let you know, thanks for a timely response - lol :) |
ipolevoy
force-pushed
the
master
branch
2 times, most recently
from
f2f2f43
to
7e51945
Compare
No description provided.