Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed off by 1 error, otherwise geoJson Search always goes at least 2 levels deep... #434

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SpocWeb
Copy link
Contributor

@SpocWeb SpocWeb commented Feb 13, 2024

...even when only a single / is appended.

Pull Request Description

Hi, this PR fixes an off-by-1 error that leads to extremely long loading times (hours),
when you have many geojson Files in deeper nested directories.

Changes Proposed

By reducing the initial Counter to 1 you can limit the depth to just the given Directory.
I have tested it with all my Repos, e.g. this: https://github.com/SpocWiki/Europe-Germany

Related Issues

Breaking change:
Of course this means that everyone needs to append a single '/' to get the results as before.

Fixes #Issue_Number

Checklist

  • I have read the contribution guidelines and code of conduct.
  • I have tested the changes locally and they are working as expected.
  • I have added appropriate comments and documentation for the code changes.
  • My code follows the coding style and standards of this project.
  • I have rebased my branch on the latest main (or master) branch.
  • All tests (if applicable) have passed successfully.
  • I have run linters and fixed any issues.
  • I have checked for any potential security issues or vulnerabilities.

Screenshots (if applicable)

Additional Notes

none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant