Support for templates for JNLPBundler, and support for bundler parameters 'title' and 'description' #332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the third attempt to get my pull request accepted and integrated, after #94 and #122 were declined, and a feature proposed in #122 was later integrated in #255.
The commit I am asking you to integrate allows for three further bundler parameters:
jnlpTemplates
-- a list of HTML files to be processed as templates byJNLPBundler
title
-- a title to be used by any supporting bundler, and which defaults to${project.name}
description
-- a description to be used by any supporting bundler, and which defaults to${project.description}
Although @FibreFoX has integrated the option to specify
<bundleArguments>
andjnlp.templates
is aStandardBundlerParam
, cf.JNLPBundler
, such a list of files cannot be parsed from thepom.xml
, since a String converter is missing, seeJNLPBundler
. My solution to this works as follows.jnlpTemplates
is defined in theNativeMojo
.<jnlpTemplate>
entries (within<jnlpTemplates>
) pointing to files to be used as templates by theJNLPBundler
.NativeMojo
for the bundlerjnlp
, then thisList<File>
is converted into aMap<File,File>
, see Lines 757-765, and theMap<File,File>
is then added toparamsToBundleWith
with keyjnlp.templates
.NativeMojo
, the processed HTML files can be found intarget/jfx/native
.In case one needs further control on where to output and store the processed HTML files, one could extend the field
jnlpTemplates
to allow for the declaration of pairs of input and output files. Currently, it is only a list of input files the names of which are used as names of the output files undertarget/jfx/native
.