This repository has been archived by the owner on May 28, 2018. It is now read-only.
Fix Netty for unsized large responses #3790
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HttpChunkedInput needs to be flushed so that it can read input immediately. Otherwise, all writes are buffered until the response is fully written, which overflows the buffer if enough data is sent. This only partially fixes the problem since clients that are reading slower than one chunk per 10sec can still overflow the buffer, but it is often sufficient in practice. To fully fix, JerseyChunkedInput needs to be reworked to block indefinitely when there's no space but to allow the ChunkedInput.close to awaken the writer and throw an IOException. (The existing close implements both the OutputStream and ChunkedInput, but it appears to be implemented as the latter only, so the removeLast/add appears to race with concurrent writes.)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpChunkedInputneeds to be flushed so that it can read input immediately. Otherwise, all writes are buffered until the response is fully written, which overflows the buffer if enough data is sent.This only partially fixes the problem since clients that are reading slower than one chunk per 10sec can still overflow the buffer, but it is often sufficient in practice. To fully fix,
JerseyChunkedInputneeds to be reworked to block indefinitely when there's no space but to allow theChunkedInput.closeto awaken the writer and throw anIOException. (The existing close implements both theOutputStreamandChunkedInput, but it appears to be implemented as the latter only, so theremoveLast/addappears to race with concurrent writes.)Updates #3500
(I am listed for Jersey in the Oracle Contributor Agreement under "Workiva Inc.")