Replace all instances of '_' with '-' in header name before proxying. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures compatibility when proxying Heroku requests to other Heroku apps
bethesque
pushed a commit
to bethesque/rack-reverse-proxy
that referenced
this pull request
Aug 3, 2017
https fixes and a new feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably the least general of the patches I've sent over. Basically I am using the rack-reverse-proxy to funnel traffic from a Heroku Bamboo application to a Cedar application. Because of the way Heroku works with HTTP headers, I needed to replace the underscores with hyphens before passing the traffic back to the next Heroku app. I am happy to wrap this into an option (not really sure what to call it?) and add some tests if there's interest in merging it. Let me know.