Comment about combined defaults and extend #4267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squashed from the original commits in jashkenas#4088.
paulfalgout
approved these changes
Jul 20, 2023
jgonggrijp
deleted the
feature/comment-about-combined-defaults-and-extend
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal replaces #4088 by @unclechu. I squashed their commits and then changed the comment again in a commit of my own. In this way, @unclechu is still credited for their effort to document the code, although their PR will be marked as rejected.
In my opinion, the line in question was misguided (see also #4266). It has no advantage over a simple call to
_.defaults, except that it allows you to set attribute keys that collide withObject.prototypeproperties. I consider that a footgun rather than a feature.Reviews welcome.