-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package C extension to wheel #225
base: master
Are you sure you want to change the base?
Conversation
Thanks for your contribution. I have some questions:
I see some remaining TODOs:
|
Thank you for the review.
|
@adamchainz @ringsaturn @joshuadavidthomas Can anyone jump in an help me out here? I am currently too busy to read into this, but I don't want to leave this valid PR pending. |
Thanks for reaching out, however I'm too busy to handle this. I suggest to get in touch with https://github.com/hugovk who help ujson's development a lot ultrajson/ultrajson#343. |
I can make an initial implementation of cibuildwheel next week, but it will be complicated to test it properly. |
@jannikmi Appreciate the ask, and I wish I could lend a hand, but I have only ever worked with pure Python packages and have never written a line of C code in my life. I'm not sure how much help I can be. 🫤 |
Thanks. I am sorry this topic is too far from my area of expertise that I cannot be of much help. What would you need to test the changes? |
Existing published wheels do not include the native C extension
inside_polygon_ext
. The default distribution could be quite slow if the library consumer doesn't install Clang, GCC, and ffi-dev to build dependencies. To clarify, it doesn't relate to Numba support.Added an
auditwheel
check to the GitHub Actions check extension compatibility with manylinux specification. It's probably needed to adjust it based onauditwheel
check.How to verify check C extension support:
assert(TimezoneFinder.using_clang_pip())
. Checked it on a local project with a private PyPi repository.