Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique name queues #294

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

farhadnowzari
Copy link

The issue related to this PR is. #284

A new extension method is added to the ServicesCollection, AddQueues.
This method will get an action which has the IServicesCollection as the parameter so you can use AddQueue as you would do normally.
Also it will inject IQueues into DI so you can query for the registered queues.

The ToDos in my opinion are as follow:

  1. On AddQueues method it should NOT be possible that inside the action we can again call AddQueues . Maybe we can replace the IServicesCollection with QueuesOption and this class will provide the AddQueue method.
  2. At the moment in Coravel it is configurable that how often the worker run the single queue but since we have now multiple queues I think this should also have a configuration in appsettings.json. If they specify the old config it would be apply for all but if they specify the name of the queue as the key and the value will be the delay inside appsettings we can adjust each queue.
  3. The queue name at the moment is not really unique. On adding them to the DI we should check if the same name is already added or not and handle the error accordingly.

@farhadnowzari
Copy link
Author

Hi @jamesmh

Let me know if anything is needed regarding thie PR

@skobbejakkals
Copy link

Any news on this? This would be very useful.

@jaisonass
Copy link

Any update on this?

@bCamba
Copy link

bCamba commented Feb 25, 2024

This would be so useful if it got merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants