Issue and tissue #368
Open
Issue and tissue #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Significant optimizations for ROI rendering in Studio - New advanced ROI editing window in Studio (WIP), including "merge" and "simplify" functions
- Various fixes with interaction between ROIs and QC, when roi_filter_method is set to a float value - Studio: add ability to change roi_filter_method
- Add `WSI.get_tile_roi_mask()` for obtaining a whole-tile mask of ROIs - Experimental "point" ROI option in Studio (currently just adds a circle)
…me GANs in Studio
… when the size of the last batch is 1)
…hey are structured
…esize` - Rework pytorch pathology pretrained feature extractors to no longer accept the `tile_px` argument, instead accepting `center_crop` or `resize` arguments directly. Previous behavior was to set `center_crop=True` if the `tile_px` did not match the tile size of the model. This disables this behavior and gives the user the ability to choose how mismatched image sizes are handled (crop vs resize)
…is not encoded in the expected manner
…es (`dataset.extract_tiles(mpp_override=...)`)
Updating invert_roi and functions to process tissues_n_issues
Update invert_roi() to work correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These addition allow to specify a list RoI labels that shuold be treated as issues (artifacts), meaning that should be excluded in the tile extraction.
Inside
wsithe artifact RoIs are still stored in their normal form but the newutils.invert_roifunction invert them when needed.This approach was chosen because to compute the final grid for extraction we need to invert the artifact RoIs do the intersection between them and finally do the intersection between the result and the union of the normal RoIs.
(⋃{RoIs}) ⋂ (⋂{artifacts})