Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom command to launch frequently used URL #1363

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

Wobak
Copy link

@Wobak Wobak commented Apr 27, 2023

This pull request...

  • [ x ] Introduces a new feature

Description

This commands implements the custom command which allows to use the shortcuts config to run commands such as
!custom mymusic to avoid using the full URL every time.

Purpose

When using the same music multiple times, it might be useful to add it in the config for custom calls

Relevant Issue(s)

None noted

Wobak and others added 3 commits April 27, 2023 00:39
@MichailiK
Copy link
Collaborator

You seem to have changed every file's mode/permission in the project, thus creating a diff out of every file. You also unintentionally committed binaries and other unwanted files into your branch. Please undo those, then force-push your changes into the branch.

@Wobak
Copy link
Author

Wobak commented Apr 27, 2023

Hello,

OK let me try to review that.

However the binaries are now in the main project as part of last commit : https://github.com/jagrosh/MusicBot/tree/master/src/main/resources/natives

@MichailiK
Copy link
Collaborator

Oh. I apologize, I never noticed they were added. I got confused, since every file is being shown as modified in this PR. It'd be great if all the files can be reset back to how they are in our master branch.

@Wobak
Copy link
Author

Wobak commented Apr 27, 2023

We added 2 commits with the reset of permissions and the new code logic. Let me know if this is good or not :)

@Wobak
Copy link
Author

Wobak commented Apr 27, 2023

I'm changing a few things for the integration to be more consistent with the rest of the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants