Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build wheel by requirements.txt not pack #431

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ValMystletainn
Copy link

Thanks for the convenient and amazing collection for all the grad-cam based method.
You just published the 1.4.7 version in June, 15, 2023. As for the changing in setuptool, people cannot install the from pip install grad-cam right now.

It will come into a build failure in wheel like this

  1. on macos
企业微信截图_65e1c361-45b8-4e57-af43-5d93bb562c6f 2. on linux

企业微信截图_6f68287d-817c-4fee-89e9-5f5bf6b08976

the setup.py need requirement.txt as usual, but the setuptools changing in recent half years make it not pack requirement.txt anymore.
This PR is a fast and minial fixing, just adding a config file reading by wheel builder to include requirements.txt mannully
If you need I can make a PR to turn the whole package into a modern pakcage tool like poetry with full tests.

Reference:

  1. include-requirements-txt-file-in-python-wheel: https://stackoverflow.com/questions/38533669/include-requirements-txt-file-in-python-wheel
  2. setuptools not support the MANIFEST.in setting yet: [FR] Support specifying MANIFEST.in config via pyproject.toml pypa/setuptools#3341
  3. poetry setting: https://python-poetry.org/docs/pyproject/#include-and-exclude

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant