Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed seg fault while recovering wallet by making encryption optional… #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeredkenna
Copy link

I was getting a seg fault trying to recover a wallet and save it without a password.
Really simple change but if you want to pull this and branch it then some people might find the version useful.

@bitcoinwarrior1
Copy link

Hi, when it gives a segment fault does that mean that the passphrase is incorrect if a passphrase is provided? Thanks

@jackjack-jj
Copy link
Owner

It's actually a choice to enforce encryption of recovered wallets, I don't want to be responsible of leaked keys
I could have been clearer though so I'll leave that open until done
Also I don't get how this can lead to a segfault

@wendtl
Copy link

wendtl commented Feb 23, 2021

I ran into this issue when I was using an older version of pywallet. I did not have pycrypto properly installed and installing it correctly fixed the issue. I'd have to revisit the updated code to see if I can still replicate the issue but I believe it had something to do with the fallback that was being used when pycrypto was not installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants