Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for new 'tick_double' field in 'jack_position_t' (fixes #8) #12

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: add support for new 'tick_double' field in 'jack_position_t' (fixes #8) #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion jacklib/api.py
View file
Open in desktop
Expand Up @@ -213,12 +213,15 @@ def _d(s, encoding=ENCODING):
JackBBTFrameOffset = 0x40
JackAudioVideoRatio = 0x80
JackVideoFrameOffset = 0x100
# JACK2 1.9.19+:
JackTickDouble = 0x200
JACK_POSITION_MASK = (
JackPositionBBT
| JackPositionTimecode
| JackBBTFrameOffset
| JackAudioVideoRatio
| JackVideoFrameOffset
| JackTickDouble
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesnt match jack2 headers. JACK_POSITION_MASK in jack2 only has JackPositionBBT|JackPositionTimecode set. but that seems to be a jack2 issue.
then jack1/shared is missing the new JackTickDouble hmmm :/

not a problem for you, just noticed this inconsistency in jack headers

)

# enum JackSessionEventType
Expand Down Expand Up @@ -268,7 +271,8 @@ class jack_position_t(Structure):
("bbt_offset", jack_nframes_t),
("audio_frames_per_video_frame", c_float),
("video_offset", jack_nframes_t),
("padding", ARRAY(c_int32, 7)),
("tick_double", c_double),
("padding", ARRAY(c_int32, 5)),
("unique_2", jack_unique_t),
]

Expand Down