Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LMS1xx Lidar working #137

Open
wants to merge 17 commits into
base: foxy-devel
Choose a base branch
from

Conversation

brendoncintas
Copy link

Hello,

I was hell-bent on using the Sick LMS1xx lidar in my Gazebo simulator. So, here it is.

I also changed it from /front/scan to /scan, but this could be changed back.

Copy link
Member

@tonybaltovski tonybaltovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! There a few things that need to be stored out before merging. Here is a first pass.

@@ -1,5 +1,6 @@
controller_manager:
ros__parameters:
use_sim_time: False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't be here for real robots.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line doesn't exist on my packages on the real robot (I don't commit and push on the real robot, which is likely why you see it here and not there. Though, I'm curious - if we set it to False, would this be sufficient?)

output='screen',
parameters=[config_jackal_ekf],
),
# Node(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be enabled.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had this disabled as I was testing my real robot using a different odometry package for 2D laser scans - rf2o_laser_odometry. I'll enable this again for now.

jackal_control/launch/teleop_base.launch.py Outdated Show resolved Hide resolved
jackal_description/urdf/accessories.urdf.xacro Outdated Show resolved Hide resolved
<xacro:property name="tower" value="$(optenv JACKAL_LASER_TOWER 1)" />
<xacro:property name="prefix" value="$(optenv JACKAL_LASER_PREFIX ${mount})" />
<xacro:property name="parent" value="$(optenv JACKAL_LASER_PARENT ${mount}_mount)" />
<xacro:property name="lidar_model" value="$(optenv JACKAL_LASER_MODEL ust10)" />
<xacro:property name="lidar_model" value="$(optenv JACKAL_LASER_MODEL lms1xx)" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert to match our preference.

@@ -91,7 +91,7 @@
<origin xyz="0 0 ${height}" rpy="0 0 0" />
</joint>

<xacro:VLP-16 parent="${prefix}_vlp16_plate" topic="${topic}">
<xacro:VLP-16 parent="${prefix}_vlp16_plate" name="velodyne" topic="/velodyne_points" organize_cloud="false" hz="10" samples="440" gpu="false">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert to match our preference.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I attempted to use just the original line 94 for this, and the LiDAR would not spawn with the /velodyne_points topic. After referring to the example urdf file from velodyne_description, I was able to see the /velodyne_points topic being published when applying the same xacro parameters. (Refer to here).

jackal_navigation/config/nav2.yaml Outdated Show resolved Hide resolved
jackal_navigation/config/nav2.yaml Outdated Show resolved Hide resolved
jackal_navigation/config/slam.yaml Outdated Show resolved Hide resolved
@@ -1,4 +1,4 @@
# Copyright 2022 Clearpath Robotics, Inc.
# Copyright (c) 2018 Intel Corporation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the change here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, I changed the nav2.launch.py file to the original navigation_launch.py file in the nav2_bringup package (found here) because the default nav2.launch.py didn't seem to be working.

resolution: 0.025
robot_radius: 0.3
footprint: "[ [0.254, 0.2159], [0.254, -0.2159], [-0.254, -0.2159], [-0.254, 0.2159] ]"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as #139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants