New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pagination logic when searching to add videos to a playlist #4555
Update pagination logic when searching to add videos to a playlist #4555
Conversation
That's much simpler than what I had in mind ^^ (which involved returning the continuation token from very far in the call stack) |
Still doesn't work.
Here I tested searching for |
@SamantazFox yeah, looks like this PR isnt working because #4583 is no longer working |
Also, I think you're using the search page in the screenshot (which was not modified by this code, I only modified the screen where you search videos to add to a playlist |
You're right .-. |
2d246f8
to
661d197
Compare
Btw this will show the next page button even if there's no next page: #4126 which is why I closed this PR |
Closing as this might not be a proper fix (as long as regular search's pagination isn't working) |
The old logic would filter the results and use the count of the filtered results to determine if a next page should be shown. If there were playlists or channels then the next page button would not be shown even if there was a next page.