Overhaul VideoJS dependency manager #4438
Draft
+335
−160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor into dedicated class - Simplify workarounds for dependencies with differing structure
Crystal now supports OpenSSL 3 Reverts 4e629ca
This allows for using the native crystal File.copy function and the caching of downloaded tarballs.
|
This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked. |
|
Is there something I can do to help get this back on track? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors code in the script
Simplify workarounds for dependencies with differing structure
Adds check for missing dependency files in assets/videojs/* in case of improper installation
Use native Crystal digest for checksum instead of system command
Don't clear the cache each time the script is, instead there's the parameter
--clear-cacheor the compile time flagclear_player_dependencies_cachewhen ran through Invidious.Changes the default cache directly to be relative to the Invidious repo
Adds ability to use a custom NPM registry
Adds ability to change the cache directory
Allows using pre-existing downloaded tarballs of the dependencies
Logs checksum when validation fails.
Allows skipping checksum with the
--skip-checksumparameter when calling the script directly, or theskip_player_dependencies_checksumcompile-time flag when used through Invidious