Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude test files from rollup #608

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

juliangilbey
Copy link

Summary

Proposed changes

This PR brings the following changes:

  • Only rollup the run-time files; exclude test files. (Otherwise many errors are produced.)

How to test

Describe the tests that you ran to verify your changes:

  1. Run the build
  2. Observe that you don't get dozens of warnings about unrecognised functions such as "expect".

Test configuration

  • Node.js version (if applicable): 18.12.1

Checklist

  • I have added corresponding labels to this PR (like bug, enhancement...); it's a bug, but I don't know how to add labels
  • My commits follow the Conventional Commits 1.0 Guidelines;
  • My code follows the style guidelines of this project;
  • I have performed a self-review of my own code;
  • I have mapped technical debts found on my changes; N/A
  • I have made changes to the documentation (if applicable); N/A
  • My changes generate no new warnings or errors;

@juliangilbey
Copy link
Author

I should have added; this patch was written by Israel Galadima

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant