Skip to content

Commit

Permalink
Actually adding the Chromium workaround
Browse files Browse the repository at this point in the history
  • Loading branch information
istvan-ujjmeszaros committed Apr 25, 2020
1 parent 8622d20 commit e34cd13
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 7 deletions.
9 changes: 6 additions & 3 deletions dist/jquery.bootstrap-duallistbox.js
Expand Up @@ -206,10 +206,13 @@
selectopt.detach().appendTo(select);
}

function sortOptions(select) {
function sortOptions(select, dualListbox) {
select.find('option').sort(function(a, b) {
return ($(a).data('original-index') > $(b).data('original-index')) ? 1 : -1;
}).appendTo(select);

// workaround for chromium bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1072475
refreshSelects(dualListbox);
}

function clearSelections(dualListbox) {
Expand Down Expand Up @@ -238,7 +241,7 @@
if(dualListbox.settings.sortByInputOrder){
sortOptionsByInputOrder(dualListbox.elements.select2);
} else {
sortOptions(dualListbox.elements.select2);
sortOptions(dualListbox.elements.select2, dualListbox);
}
}

Expand All @@ -259,7 +262,7 @@

refreshSelects(dualListbox);
triggerChangeEvent(dualListbox);
sortOptions(dualListbox.elements.select1);
sortOptions(dualListbox.elements.select1, dualListbox);
if(dualListbox.settings.sortByInputOrder){
sortOptionsByInputOrder(dualListbox.elements.select2);
}
Expand Down

0 comments on commit e34cd13

Please sign in to comment.