Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HTTP/1.1, negotiated by ALPN #681

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

howardjohn
Copy link
Member

No description provided.

@howardjohn howardjohn requested a review from a team as a code owner September 15, 2023 22:57
@howardjohn howardjohn added the release-notes-none Indicates a PR that does not require release notes. label Sep 15, 2023
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 15, 2023
@yuval-k
Copy link
Contributor

yuval-k commented Sep 16, 2023

Hi @howardjohn, What's the context/background for this change? I may have missed it, but haven't seen anything mentioned in the weekly meeting notes.

I'm asking as given that envoy (and other modern proxies/servers) support h2, I'm not sure if it is worth the extra complexity to add h1 support.
This means that we have 2 protocols with different buffering and connection semantics to tune and optimize now and down the road.

@howardjohn
Copy link
Member Author

Hi @howardjohn, What's the context/background for this change? I may have missed it, but haven't seen anything mentioned in the weekly meeting notes.

I'm asking as given that envoy (and other modern proxies/servers) support h2, I'm not sure if it is worth the extra complexity to add h1 support. This means that we have 2 protocols with different buffering and connection semantics to tune and optimize now and down the road.

The motivations were compatibility and performance. However, our possible compatibility use cases haven't come to fruition yet and I haven't had time to test/prove performance benefits at all. Lets keep this on the backburner for now unless its value becomes more apparent

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Jan 20, 2024
@istio-testing
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR needs to be rebased before being merged release-notes-none Indicates a PR that does not require release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants