update install instruction and clean up scripts

[richardwxn]

1. update instruction to avoid confusion
2. remove stale install from operator repo script
3. use istioctl as default for script

/cc @incfly

[incfly]

setup_istio_releaess.sh also support specific SHA as well right? could you add an example here?

export ISTIO_RELEASE=1.6-alpha.0ef2cd46e2da64b9252c36ca4bf90aa474b73610, something like that.

[howardjohn]

fwiw, I have a script I have started on locally but haven't gotten around to merging, that supports install of any release:

WD=$(dirname "$0")
WD=$(cd "$WD"; pwd)
DIRNAME="${WD}/tmp"
mkdir -p "${DIRNAME}"
export GO111MODULE=on

# Passing a tag, like latest or 1.4-dev
if [[ -n "${TAG:-}" ]]; then
  VERSION=$(curl -sL https://gcsweb.istio.io/gcs/istio-build/dev/"${TAG}")
  OUT_FILE="istio-${VERSION}"
  RELEASE_URL="https://storage.googleapis.com/istio-build/dev/${VERSION}/istio-${VERSION}-linux.tar.gz"
# Passing a dev version, like 1.4-alpha.41dee99277dbed4bfb3174dd0448ea941cf117fd
elif [[ -n "${DEV_VERSION:-}" ]]; then
  OUT_FILE="istio-${DEV_VERSION}"
  RELEASE_URL="https://storage.googleapis.com/istio-build/dev/${DEV_VERSION}/istio-${DEV_VERSION}-linux.tar.gz"
# Passing a version, like 1.4.2
elif [[ -n "${VERSION:-}" ]]; then
  OUT_FILE="istio-${VERSION}"
  RELEASE_URL="https://storage.googleapis.com/istio-prerelease/prerelease/${VERSION}/istio-${VERSION}-linux.tar.gz"
# Passing a release url, like https://storage.googleapis.com/istio-prerelease/prerelease/1.4.1/istio-1.4.1-linux.tar.gz
elif [[ -n "${RELEASE_URL:-}" ]]; then
  OUT_FILE=${OUT_FILE:-"$(basename "${RELEASE_URL}" -linux.tar.gz)"}
# Passing a gcs url, like gs://istio-build/dev/1.4-alpha.41dee99277dbed4bfb3174dd0448ea941cf117fd
elif [[ -n "${GCS_URL:-}" ]]; then
  DOWNLOAD_TYPE=gcs
  RELEASE_URL="${GCS_URL}"
  OUT_FILE=${OUT_FILE:-"$(basename "${RELEASE_URL}" -linux.tar.gz)"}
fi

if [[ -z "${RELEASE_URL:-}" ]]; then
  echo "Must set on of TAG, VERSION, DEV_VERSION, RELEASE_URL, GCS_URL"
  exit 2
fi

function download_release() {
  outfile="${DIRNAME}/${OUT_FILE}"
  if [[ ! -d "${outfile}" ]]; then
    tmp=$(mktemp -d)
    if [[ "${DOWNLOAD_TYPE:-}" == gcs ]]; then
      gsutil cp "${GCS_URL}" "${tmp}/out.tar.gz"
      tar xvf "${tmp}/out.tar.gz" -C "${DIRNAME}"
    else
      curl -fJLs -o "${tmp}/out.tar.gz" "${RELEASE_URL}"
      tar xvf "${tmp}/out.tar.gz" -C "${DIRNAME}"
    fi
  else
    echo "${outfile} already exists, skipping download"
  fi
}

function install_istioctl() {
  release=${1:?release folder}
  shift
  "${release}/bin/istioctl" manifest apply --skip-confirmation --wait "${@}"
}

function install_gateways() {
  helm template --set domain="${domain}" base | kubectl -n istio-system apply -f -
}

function install_prom_op() {
  "$WD/setup_prometheus.sh" "${DIRNAME}"
}

download_release
install_istioctl "${DIRNAME}/${OUT_FILE}" "${@}"

install_prom_op
install_gateways

[incfly]

I did a grep, and see perf/load/auto-mtls/README.md has reference on the operator script as well. could you replace that to the new cmd? No need to verify, just avoid dangling reference.

[istio-testing]

@richardwxn: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[carolynhu]

@richardwxn just want to check, are you going to finish this PR or it is stale. thank you.

[istio-testing]

@richardwxn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
containers-test-arm64_tools	60e4e91	link	true	/test containers-test-arm64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.