Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ppc64le architecture for build-tools images #1681

Closed
wants to merge 1 commit into from

Conversation

MatthieuSarter
Copy link

This allows to build the build-tools and build-tools-proxy images for ppc64le.

Some tools are missing a ppc64le build, for now I skipped them, they seem not mandatory to build istio.

I also had to bump docker and containerd versions, respectively from 20.10.6 to 20.10.7 and from 1.4.3 to 1.4.6, as previous versions are not available on ppc64le.

Please note that I have not been able to test if the image still builds on ARM64.

Signed-off-by: Matthieu Sarter <matthieu.sarter@ibm.com>
@MatthieuSarter MatthieuSarter requested a review from a team as a code owner August 25, 2021 09:00
@istio-policy-bot
Copy link

😊 Welcome @MatthieuSarter! This is either your first contribution to the Istio tools repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Aug 25, 2021
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 25, 2021
@istio-testing
Copy link
Contributor

Hi @MatthieuSarter. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MatthieuSarter MatthieuSarter changed the title Support for ppc64le architecture Support for ppc64le architecture for build-tools images Aug 25, 2021
Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats the end goal? Are we expecting someone to build a full Istio build (with envoy) on ppc64le and actually use it?

I am a bit hesitant to make this super complex with emulated builds etc. For ARM its a bit different since there is substantial demand for production workloads, as well as cloud support. While we are emulating right now, soon we will have ARM CI nodes. I doubt we will ever have ppc64le nodes...

@MatthieuSarter
Copy link
Author

Yes our goal is to build a full istio on ppc64le.

I understand your concerns about the difficulty to include the ppc in the CI workflow. I will see with my management if we can do something about this.

@MatthieuSarter
Copy link
Author

@howardjohn , we can provide you ppc64le VMs hosted at OSU Open Source Lab.

If this is ok for you, you can request nodes through this form, with Christy Norman (@clnperez) as "IBM Advocate".

If this does not meet your requirements, you can give me more details about your needs and we will see what we can do.

@howardjohn
Copy link
Member

I think in order to add an official support architecture we will need, at a minimum:

  • Substantial demand from Istio users
  • Official support from prow, our CI/CD system
  • Enough capacity to run our builds and tests - at least 500 vCPUs.
  • Ability for our development team to develop, test, and debug - ie access to machines with the architecture

I haven't seen much demand, if any, from Istio users for this.

@istio-testing
Copy link
Contributor

@MatthieuSarter: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Sep 9, 2021
@clnperez
Copy link

clnperez commented Nov 9, 2021

@howardjohn can we negotiate on that substantial demand requirement? We're willing to provide the human and compute resources for supporting ppc64le; and, like any project we're involved in, will upkeep the CI, fix issues, and contribute in more general ways. If at any time you feel we're not contributing we wouldn't begrudge being kicked out of the project. ;)

We're trying to future-proof for Power customers. Someone is less likely to become or stay a Power customer if not much software supports it. Of course we also understand that there has to be some benefit to you. istio on Power has the potential to attract some large customers of course, but, in addition, there is the added benefit of hardening projects on larger systems. In projects like Docker, Kubernetes, and go (projects I've been involved in), Power and s390x hit scale issues and stress projects in ways that make them more robust.

And FYI, I've done some background work to get envoy building on ppc64le, and that's been upstream for quite a while. We can build and run istio on ppc64le as well, just would like to be given the opportunity to get that code upstream.

==

Another option is that we get the support to build the code in and run our own CI, and you can think about "support" later.

🙏🏻

@howardjohn
Copy link
Member

howardjohn commented Nov 9, 2021 via email

@howardjohn howardjohn closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. needs-ok-to-test needs-rebase Indicates a PR needs to be rebased before being merged size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
5 participants