images: start building an apko-general iptables image #50545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardjohn
added
the
release-notes-none
|
Skipping CI for Draft Pull Request. |
istio-testing
added
do-not-merge/work-in-progress
howardjohn
added
do-not-merge/hold
howardjohn
force-pushed
the
docekr/apko-builder
branch
from
89b3dd2
to
38549dd
Compare
istio-testing
added
the
size/M
howardjohn
changed the title
howardjohn
requested review from
a team,
costinm,
linsun,
stevenctl,
ericvn and
hzxuzhonghu
as code owners
istio-testing
removed
the
do-not-merge/work-in-progress
howardjohn
force-pushed
the
docekr/apko-builder
branch
from
38549dd
to
95911ca
Compare
costinm
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Great idea.
Few suggestions ( we can do that in separate PRs):
- add envoy user too, 1337
- can use use /home/istio-proxy as home ?
As a larger topic, should we maybe explore a base image for sidecars without iptables - for istio-CNI users ? As we move towards ambient and sandwitched sidecars, plus sidecar containers - it may be worth having a more secure and constrained image - would also be good for waypoints/gateways.
jacob-delgado
approved these changes
Apr 22, 2024
For istio#44510 This will need a PR to istio/tools to add `apko`, so putting a hold. Note this doesn't yet change Istio to use it, only to build it.
howardjohn
force-pushed
the
docekr/apko-builder
branch
from
afebaa0
to
49b1182
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #44510
This will need a PR to istio/tools to add
apko, so putting a hold.Note this doesn't yet change Istio to use it, only to build it.