Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test homepage changes for preview. #14996

Open
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

craigbox
Copy link
Contributor

Working PR; do not merge.

@craigbox craigbox requested a review from a team as a code owner April 30, 2024 00:38
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 30, 2024
@craigbox craigbox added do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 30, 2024
@craigbox craigbox requested a review from a team as a code owner April 30, 2024 00:56
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 30, 2024
@craigbox
Copy link
Contributor Author

craigbox commented May 1, 2024

https://deploy-preview-14996--preliminary-istio.netlify.app/

Before this is "finished" we should:

  • use proper CSS for the subheading
  • use proper CSS to get the "What is Istio" text the right size
  • add some sort of graphic to float right in that section (mockup)
  • fix the alignment of the logos (vertically center the images)
  • fix the width of the logos (test on mobile)
  • choose different logos; those were just the first that we had full case studies for
  • align the bottom of the buttons in the "features" section

(@mikemorris @keithmattix or any other volunteers!)

@mikemorris
Copy link
Member

mikemorris commented May 3, 2024

Suggested fixes in craigbox#3 for

  • align the bottom of the buttons in the "features" section

and in craigbox#4 for

  • use proper CSS for the subheading
  • use proper CSS to get the "What is Istio" text the right size

Docs for case study scroller that needs fixing are at https://splidejs.com/guides/auto-width/ if anyone wants to give that a shot, I found it a bit glitchy and ran out of time.

@craigbox craigbox requested a review from a team as a code owner May 9, 2024 03:33
@craigbox
Copy link
Contributor Author

craigbox commented May 9, 2024

I've merged in Mike's fixes (thanks!) and think that we could probably go live with this, but we would like to still make the following improvements:

  • change the "What is Istio" section into body text & a floating image (see mockup)) - depends on actually having an image
  • make the slider work on mobile. I didn't have any luck with the autoWidth setting myself and figuring out why is beyond my interest and ability.

@istio-testing
Copy link
Contributor

@craigbox: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
lint_istio.io 55c542a link true /test lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants