Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ztunnel hairpinning from docs #14995

Merged
merged 6 commits into from May 1, 2024

Conversation

MorrisLaw
Copy link
Contributor

Description

Related to #14983 (this is one of a few PRs that will be made to refresh the docs in an effort to ensure continuous progress is made as opposed to holding everything up on one big documentation PR)

Removes ztunnel hairpinning from docs since it has now been removed from the codebase. See Ztunnel PR #913.

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

@istio-policy-bot
Copy link

😊 Welcome! This is either your first contribution to the Istio documentation repo, or
it's been a while since you've been here. A few things you should know:

  • You can learn about how we write and maintain documentation, our style guidelines,
    and the available web site features by visiting Contributing to the Docs.

  • In the next few minutes, an automatic preview of your change will be built with
    a full copy of the istio.io website. You can find this preview by clicking on
    the Details link next to the deploy/netlify entry in the status section of this
    page.

  • We care about quality, so we've put in place a number of checks to ensure our documentation
    is top-notch. We do spell checking, sanitize the Markdown, ensure all hyperlinks point to a
    valid location, and more. If your PR doesn't pass one of these checks, you'll see a red X in the
    lint_istio.io entry in the status section. Click on the Details link to get a list of the
    problems with your PR. Fix those problems and push an update; this will automatically re-run the
    tests. Hopefully this time everything will be perfect!

  • Once your changes are accepted and merged into the repository, they will initially show up
    on https://preliminary.istio.io. The changes will be published to https://istio.io
    the next time we do a major release (which typically happens every 3 months or so).
    To publish them sooner, add a cherrypick/release-x.xx label, where x.xx is the current
    release of Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 29, 2024
Copy link
Member

@linsun linsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on removal of hairpin.

Made a comment on your clarification for out of mesh client which I think is wrong.

@MorrisLaw
Copy link
Contributor Author

@bleggett @linsun @louiscryan I think all comments have been addressed now. PTAL again, thank you!

@linsun
Copy link
Member

linsun commented May 1, 2024

LGTM, thank you @MorrisLaw !!

@bleggett bleggett mentioned this pull request May 1, 2024
11 tasks
@istio-testing istio-testing merged commit cb4cb43 into istio:master May 1, 2024
6 checks passed
wilsonwu added a commit to wilsonwu/istio.io that referenced this pull request May 2, 2024
istio-testing pushed a commit that referenced this pull request May 6, 2024
…5013)

* Sync #14995 remove ztunnel hairpinning from doc into Chinese

* Update content/zh/docs/ambient/usage/ztunnel/index.md

Co-authored-by: Michael <haifeng.yao@daocloud.io>

---------

Co-authored-by: Michael <haifeng.yao@daocloud.io>
wilsonwu added a commit to wilsonwu/istio.io that referenced this pull request May 6, 2024
istio#15013)

* Sync istio#14995 remove ztunnel hairpinning from doc into Chinese

* Update content/zh/docs/ambient/usage/ztunnel/index.md

Co-authored-by: Michael <haifeng.yao@daocloud.io>

---------

Co-authored-by: Michael <haifeng.yao@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ambient kind/docs size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants