Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ambient: add istioctl installation #14918

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

ambient: add istioctl installation #14918

wants to merge 11 commits into from

Conversation

daixiang0
Copy link
Member

@daixiang0 daixiang0 commented Apr 19, 2024 •
edited

Description

Fix #14903

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

@daixiang0 daixiang0 requested a review from a team as a code owner April 19, 2024 03:11
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 19, 2024
hanxiaop
hanxiaop reviewed Apr 19, 2024
View reviewed changes
Copy link
Member

@hanxiaop hanxiaop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a test for this page?

@daixiang0
Copy link
Member Author

Can you also add a test for this page?

Will do.

@daixiang0 daixiang0 force-pushed the install branch 2 times, most recently from fcb2ef3 to d738b5b Compare April 19, 2024 05:59
@daixiang0 daixiang0 requested a review from hanxiaop April 19, 2024 06:58
@daixiang0
Copy link
Member Author

@hanxiaop done.

@ericvn
Copy link
Contributor

ericvn commented Apr 23, 2024

This PR is using the older ambient doc location vs the newer upper level in #14933.

@daixiang0
Copy link
Member Author

#14933 does not remove alias, it can be done by another PRs, I just keep it here.

@daixiang0 daixiang0 requested a review from a team as a code owner May 6, 2024 02:45
@daixiang0
Copy link
Member Author

/retest

@daixiang0
Copy link
Member Author

Looks that he CI failure is not related.

hanxiaop
hanxiaop reviewed May 7, 2024
View reviewed changes
data/args.yml Outdated Show resolved Hide resolved
@daixiang0
ambient: add istioctl installation
3e12408 
Signed-off-by: Loong <loong.dai@intel.com>
@daixiang0
feedback
32e5b99 
Signed-off-by: Loong <loong.dai@intel.com>
@daixiang0
update
ff572ce 
Signed-off-by: Loong <loong.dai@intel.com>
@daixiang0
update version
6347c15 
Signed-off-by: Loong <loong.dai@intel.com>
@daixiang0
update dir
a2c22b2 
Signed-off-by: Loong <loong.dai@intel.com>
@daixiang0
make gen
2b02bb6 
Signed-off-by: Loong <loong.dai@intel.com>
@daixiang0
add alias
8ae380c 
Signed-off-by: Loong <loong.dai@intel.com>
@daixiang0
update
18217b0 
Signed-off-by: Loong <loong.dai@intel.com>
@daixiang0
feedback
a95d2a3 
Signed-off-by: Loong <loong.dai@intel.com>
@daixiang0
update api version
7d87b5f 
Signed-off-by: Loong <loong.dai@intel.com>
@daixiang0
update indentation
8553f9f 
Signed-off-by: Loong <loong.dai@intel.com>
@istio-testing
Copy link
Contributor

@daixiang0: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
doc.test.profile-demo_istio.io 8553f9f link true /test doc.test.profile-demo
doc.test.multicluster_istio.io 8553f9f link true /test doc.test.multicluster
doc.test.profile-default_istio.io 8553f9f link true /test doc.test.profile-default
doc.test.profile-none_istio.io 8553f9f link true /test doc.test.profile-none
doc.test.dualstack_istio.io 8553f9f link false /test doc.test.dualstack
doc.test.profile-minimal_istio.io 8553f9f link true /test doc.test.profile-minimal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@daixiang0
Copy link
Member Author

@ericvn seems still need alias, see https://prow.istio.io/view/gs/istio-prow/pr-logs/pull/istio_istio.io/14918/doc.test.profile-demo_istio.io/1787715229715533824

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvn ericvn ericvn left review comments

@hanxiaop hanxiaop hanxiaop left review comments

@craigbox craigbox Awaiting requested review from craigbox

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a simple istioctl install doc for ambient
5 participants
@daixiang0 @ericvn @istio-testing @craigbox @hanxiaop