quick guide on how to migrate from sidecars to ambient #14894

nauticalmike · 2024-04-17T14:40:57Z

Description

quick guide on how to migrate from sidecars to ambient

Reviewers

istio-testing · 2024-04-17T14:41:08Z

Hi @nauticalmike. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ericvn · 2024-04-17T15:23:08Z

/ok-to-test

ericvn · 2024-04-17T15:23:55Z

content/en/docs/ops/ambient/migrate/index.md

+---
+title: Migrating from Sidecars to Ambient
+description: How to migrate existing sidecar topology to Ambient
+weight: 1


Do we want this Migration doc to really be the first doc in the list?

probably not. If we do want to have this doc, it should be alpha, and not part of ambient beta.

As noted, we need to update the weight to reflect the correct position on the page. Should it be after User Guides (so a number greater than 15 and less than 20, or should this be under User Guides. I think I favor not being a User Guide.

istio-testing · 2024-04-17T15:24:30Z

@nauticalmike: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
lint_istio.io	`9296bdf`	link	true	`/test lint`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

linsun · 2024-04-17T15:28:50Z

cc @kfaseela who asked me about this before

ericvn

Initial pass. Note that the Ambient doc location was changed in a PR so this document will need to move as well.

ericvn · 2024-04-23T16:38:35Z

content/en/docs/ops/ambient/migrate/index.md

@@ -0,0 +1,333 @@
+---
+title: Migrating from Sidecars to Ambient
+description: How to migrate existing sidecar topology to Ambient


We haven't been capitalizing ambient

Suggested change

description: How to migrate existing sidecar topology to Ambient

description: How to migrate existing sidecar topology to ambient

ericvn · 2024-04-23T16:42:06Z

content/en/docs/ops/ambient/migrate/index.md

+---
+title: Migrating from Sidecars to Ambient
+description: How to migrate existing sidecar topology to Ambient
+weight: 1


As noted, we need to update the weight to reflect the correct position on the page. Should it be after User Guides (so a number greater than 15 and less than 20, or should this be under User Guides. I think I favor not being a User Guide.

ericvn · 2024-04-23T16:52:59Z

content/en/docs/ops/ambient/migrate/index.md

+1. [Adding your application to ambient](#addtoambient)
+
+## Download and install {#download}
+1.  Install [kind](https://kind.sigs.k8s.io/)


Suggested change

1. Install [kind](https://kind.sigs.k8s.io/)

1. Install [kind](https://kind.sigs.k8s.io/).

ericvn · 2024-04-23T16:55:56Z

content/en/docs/ops/ambient/migrate/index.md

+    {{< /text >}}
+
+### Determining the ingress IP and ports
+


I'm not sure if this works for me. I believe I needed to install metallb in the past, but maybe I am wrong. Need to investigate this some more. Maybe we can simply use the curls as is done after migrating to ambient mode.

ericvn · 2024-04-23T16:56:56Z

content/en/docs/ops/ambient/migrate/index.md

+***
+
+### K8s Gateway API
+


Should we have some text in this section?

ericvn · 2024-04-23T16:57:16Z

content/en/docs/ops/ambient/migrate/index.md

+
+### Disable sidecar injection {#disable}
+
+Now that we have enabled Ambient mode, we need to remove the sidecar injection label in the namespace:


Suggested change

Now that we have enabled Ambient mode, we need to remove the sidecar injection label in the namespace:

Now that we have enabled ambient mode, we need to remove the sidecar injection label in the namespace:

ericvn · 2024-04-23T16:57:45Z

content/en/docs/ops/ambient/migrate/index.md

+
+## Adding your application to the ambient mesh {#addtoambient}
+
+Ambient mesh data plane relies on the ztunnel DaemonSet to redirect traffic. Before we label the namespace to be part of an ambient mesh, check the ztunnel pods to make sure they are on a healthy state:


Suggested change

Ambient mesh data plane relies on the ztunnel DaemonSet to redirect traffic. Before we label the namespace to be part of an ambient mesh, check the ztunnel pods to make sure they are on a healthy state:

The ambient mesh data plane relies on the ztunnel DaemonSet to redirect traffic. Before we label the namespace to be part of an ambient mesh, check the ztunnel pods to make sure they are on a healthy state:

kfaseela

Since we have moved ambient docs outside ops, probably this file needs to be moved too

craigbox · 2024-04-29T07:49:34Z

see here as to where I would put it

linsun · 2024-04-30T13:16:14Z

/hold

I don't think we should merge this doc for 1.22, as it doesn't work for waypoint. Might be working for 1.21 but for 1.22, sidecars aren't aware of waypoints thus this won't work.

Again this was decided by TOC to be out of scope for 1.22 - I'd recommend us focus on must items for 1.22 first for the remaining 2 weeks before 1.22 ships.

quick guide on how to migrate from sidecars to ambient

9296bdf

nauticalmike requested a review from a team as a code owner April 17, 2024 14:40

istio-policy-bot added area/ambient kind/docs labels Apr 17, 2024

istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 17, 2024

istio-testing added the needs-ok-to-test label Apr 17, 2024

istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Apr 17, 2024

ericvn reviewed Apr 17, 2024

View reviewed changes

ericvn reviewed Apr 23, 2024

View reviewed changes

kfaseela reviewed Apr 23, 2024

View reviewed changes

linsun added the do-not-merge/hold Block automatic merging of a PR. label Apr 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

quick guide on how to migrate from sidecars to ambient #14894

quick guide on how to migrate from sidecars to ambient #14894

nauticalmike commented Apr 17, 2024 •

edited

istio-testing commented Apr 17, 2024

ericvn commented Apr 17, 2024

ericvn Apr 17, 2024

linsun Apr 17, 2024

ericvn Apr 23, 2024

istio-testing commented Apr 17, 2024

linsun commented Apr 17, 2024

ericvn left a comment •

edited

ericvn Apr 23, 2024

ericvn Apr 23, 2024

ericvn Apr 23, 2024

ericvn Apr 23, 2024

ericvn Apr 23, 2024

ericvn Apr 23, 2024

ericvn Apr 23, 2024

kfaseela left a comment

craigbox commented Apr 29, 2024

linsun commented Apr 30, 2024 •

edited

	description: How to migrate existing sidecar topology to Ambient
	description: How to migrate existing sidecar topology to ambient

	1. Install [kind](https://kind.sigs.k8s.io/)
	1. Install [kind](https://kind.sigs.k8s.io/).


		### Disable sidecar injection {#disable}

		Now that we have enabled Ambient mode, we need to remove the sidecar injection label in the namespace:


		## Adding your application to the ambient mesh {#addtoambient}

		Ambient mesh data plane relies on the ztunnel DaemonSet to redirect traffic. Before we label the namespace to be part of an ambient mesh, check the ztunnel pods to make sure they are on a healthy state:

	Ambient mesh data plane relies on the ztunnel DaemonSet to redirect traffic. Before we label the namespace to be part of an ambient mesh, check the ztunnel pods to make sure they are on a healthy state:
	The ambient mesh data plane relies on the ztunnel DaemonSet to redirect traffic. Before we label the namespace to be part of an ambient mesh, check the ztunnel pods to make sure they are on a healthy state:

quick guide on how to migrate from sidecars to ambient #14894

Are you sure you want to change the base?

quick guide on how to migrate from sidecars to ambient #14894

Conversation

nauticalmike commented Apr 17, 2024 • edited

Description

Reviewers

istio-testing commented Apr 17, 2024

ericvn commented Apr 17, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

istio-testing commented Apr 17, 2024

linsun commented Apr 17, 2024

ericvn left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kfaseela left a comment

Choose a reason for hiding this comment

craigbox commented Apr 29, 2024

linsun commented Apr 30, 2024 • edited

nauticalmike commented Apr 17, 2024 •

edited

ericvn left a comment •

edited

linsun commented Apr 30, 2024 •

edited