Ambient beta get started guide patch #14805

nauticalmike · 2024-03-29T01:27:30Z

Description

Adjusting removing the inpod from doc per @bleggett 's suggestion #14788 (comment)

Reviewers

… proxy status

Co-authored-by: Frank Budinsky <frankb@ca.ibm.com>

istio-testing · 2024-03-29T01:27:41Z

Hi @nauticalmike. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ericvn · 2024-03-29T15:00:36Z

You will need to enable the tests, removing the -disabled on the test names in the https://github.com/istio/istio.io/tree/master/content/en/docs/ops/ambient/getting-started directory (and update the test: value to say yes in the index file (causing the snips file to be regenerated)). Since this page was not passing the tests with the latest istio builds, I had hoped that your earlier PR would have fixed the tests, I have disabled them so we could move up.

Pointer to Slack discussion on the test failure: https://istio.slack.com/archives/C049TCZMPCP/p1711387715045829

ericvn · 2024-03-29T15:00:46Z

/ok-to-test

bleggett

TY! Wording SGTM, rest LGTM outside of @ericvn's comments

nauticalmike · 2024-03-29T16:23:51Z

thanks @bleggett, @ericvn will do shortly

nauticalmike · 2024-03-29T19:32:52Z

/retest

nauticalmike · 2024-03-29T20:40:09Z

@ericvn I'm hitting an issue here:

VERIFY FAILED snip_layer_7_authorization_policy_4 (timeout after 120s):
received:
"<!doctype html>
<html lang=en>
<title>405 Method Not Allowed</title>
<h1>Method Not Allowed</h1>
<p>The method is not allowed for the requested URL.</p>"
expected:
"RBAC: access denied"

What should I do here? What I mean is on this step we are supposed to get an RBAC: access denied but the verify received something else. This test was working fine before and the previous run just timed out after 1h.

nauticalmike · 2024-03-29T21:07:42Z

/retest

ericvn · 2024-04-01T12:55:45Z

@ericvn I'm hitting an issue here:
VERIFY FAILED snip_layer_7_authorization_policy_4 (timeout after 120s):
received:
"<!doctype html>
<html lang=en>
<title>405 Method Not Allowed</title>
<h1>Method Not Allowed</h1>
<p>The method is not allowed for the requested URL.</p>"
expected:
"RBAC: access denied"
What should I do here? What I mean is on this step we are supposed to get an RBAC: access denied but the verify received something else. This test was working fine before and the previous run just timed out after 1h.

Correct. This is the problem that moving up istio references causes breaking the tests. I'm not sure what the resolution should be, but see the discussion in Slack mentioned above with @ilrudie

nauticalmike · 2024-04-05T21:09:11Z

/retest

bleggett · 2024-04-09T18:58:50Z

Since this is mostly a wording fix and doctests seem to need a rework in the wake of the waypoint attach changes, suggest we leave the tests disabled here, and raise an issue to fix+enable the doctests.

ericvn · 2024-04-10T13:07:35Z

Since this is mostly a wording fix and doctests seem to need a rework in the wake of the waypoint attach changes, suggest we leave the tests disabled here, and raise an issue to fix+enable the doctests.

The tests are disabled and there already is a release blocker issue to enable and fix them: istio/istio#50145.

What you need to do in this PR would be to not rename the disabled test back so that we are trying to run it, and likely only include any index.md changes you desire. Note that the doc will need to be reworked and test rewritten in the next few weeks as I believe 1.22 is planned for release in a month or so.

nauticalmike · 2024-04-17T14:17:38Z

/retest

istio-testing · 2024-04-17T15:22:30Z

@nauticalmike: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
doc.test.profile-none_istio.io	`d5474b2`	link	true	`/test doc.test.profile-none`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

istio-testing · 2024-04-22T22:07:31Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

craigbox · 2024-04-05T23:11:51Z

content/en/docs/ops/ambient/getting-started/index.md

@@ -261,7 +261,7 @@ $ kubectl label namespace default istio.io/dataplane-mode=ambient
 Congratulations! You have successfully added all pods in the default namespace
 to the mesh. Note that you did not have to restart or redeploy anything!

-Check once again the ztunnel logs for the proxy has received the network namespace (netns) information about an ambient application pod, and has started proxying for it:
+Check the ztunnel logs for the proxy has received the network namespace (netns) information about an ambient application pod, and has started proxying for it:


Suggested change

Check the ztunnel logs for the proxy has received the network namespace (netns) information about an ambient application pod, and has started proxying for it:

Check the ztunnel logs to confirm the proxy has received the network namespace (netns) information about an application pod in ambient mode, and has started proxying for it:

craigbox · 2024-05-02T01:24:32Z

@nauticalmike please rebase and we can get the wording changes in separately from the test changes!

nauticalmike and others added 26 commits March 25, 2024 22:15

adjusting ambient getting started guide to include in-pod ztunnel log…

ef0a43f

… proxy status

Merge branch 'master' into ambient-beta-get-started-guide-patch

60936fd

removing boilerplate reference

ca132eb

removing trailing whitespaces

17707aa

removing whitespaces from snips

df83fe2

adjusting testing snips

efaba1f

adjusting testing snips for output

5ec4956

adjusting testing snips for output

0c7c11b

fixing missing validation

45cfb8f

fixing snips

34e8c60

fixing snips

da215ba

fixing snips

1fcf26d

Update content/en/docs/ops/ambient/getting-started/test.sh

aa83868

Co-authored-by: Frank Budinsky <frankb@ca.ibm.com>

fixing tests

d58395e

fixing tests

502d6e1

Update content/en/docs/ops/ambient/getting-started/index.md

7eed0a1

Co-authored-by: Frank Budinsky <frankb@ca.ibm.com>

fixing tests

80face7

fixing tests

c10c8a8

fixing tests

8dfddb1

fixing tests

8cce10f

fixing tests

c9975cf

fixing tests

815e12a

fixing tests

adba565

Update content/en/docs/ops/ambient/getting-started/test.sh

c74a627

Co-authored-by: Frank Budinsky <frankb@ca.ibm.com>

Merge branch 'istio:master' into ambient-beta-get-started-guide-patch

c1cf8f5

adjusting the ambient check before labeling per @bleggett s suggestion

b5fdfa7

nauticalmike requested a review from a team as a code owner March 29, 2024 01:27

istio-policy-bot added area/ambient kind/docs labels Mar 29, 2024

istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 29, 2024

istio-testing added the needs-ok-to-test label Mar 29, 2024

istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Mar 29, 2024

bleggett approved these changes Mar 29, 2024

View reviewed changes

nauticalmike added 3 commits March 29, 2024 12:33

updating from upstream

f8e42c4

renaming disabled tests and enabling test on index

1f4f753

adjusting output for test validation

d5474b2

nauticalmike mentioned this pull request Apr 17, 2024

[release-1.21] quick verbiage adjustment to be accurate #14895

Merged

11 tasks

istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Apr 22, 2024

craigbox reviewed May 2, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ambient beta get started guide patch #14805

Ambient beta get started guide patch #14805

nauticalmike commented Mar 29, 2024

istio-testing commented Mar 29, 2024

ericvn commented Mar 29, 2024 •

edited

ericvn commented Mar 29, 2024

bleggett left a comment •

edited

nauticalmike commented Mar 29, 2024

nauticalmike commented Mar 29, 2024

nauticalmike commented Mar 29, 2024 •

edited

nauticalmike commented Mar 29, 2024

ericvn commented Apr 1, 2024

nauticalmike commented Apr 5, 2024

bleggett commented Apr 9, 2024

ericvn commented Apr 10, 2024

nauticalmike commented Apr 17, 2024

istio-testing commented Apr 17, 2024

istio-testing commented Apr 22, 2024

craigbox Apr 5, 2024

craigbox commented May 2, 2024

	Check the ztunnel logs for the proxy has received the network namespace (netns) information about an ambient application pod, and has started proxying for it:
	Check the ztunnel logs to confirm the proxy has received the network namespace (netns) information about an application pod in ambient mode, and has started proxying for it:

Ambient beta get started guide patch #14805

Are you sure you want to change the base?

Ambient beta get started guide patch #14805

Conversation

nauticalmike commented Mar 29, 2024

Description

Reviewers

istio-testing commented Mar 29, 2024

ericvn commented Mar 29, 2024 • edited

ericvn commented Mar 29, 2024

bleggett left a comment • edited

Choose a reason for hiding this comment

nauticalmike commented Mar 29, 2024

nauticalmike commented Mar 29, 2024

nauticalmike commented Mar 29, 2024 • edited

nauticalmike commented Mar 29, 2024

ericvn commented Apr 1, 2024

nauticalmike commented Apr 5, 2024

bleggett commented Apr 9, 2024

ericvn commented Apr 10, 2024

nauticalmike commented Apr 17, 2024

istio-testing commented Apr 17, 2024

istio-testing commented Apr 22, 2024

craigbox Apr 5, 2024

Choose a reason for hiding this comment

craigbox commented May 2, 2024

ericvn commented Mar 29, 2024 •

edited

bleggett left a comment •

edited

nauticalmike commented Mar 29, 2024 •

edited