New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add operational document on configuration scoping #14702
Conversation
|
||
When [namespace isolation](/docs/reference/config/networking/sidecar/) is enabled, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is not strictly related ,but these numbers are basically made up junk from Istio 1.0. Its misleading to users to claim such a simple mapping of services => CPU.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nit for consistency, otherwise LGTM
content/en/docs/ops/configuration/mesh/configuration-scoping/index.md
Outdated
Show resolved
Hide resolved
content/en/docs/ops/configuration/mesh/configuration-scoping/index.md
Outdated
Show resolved
Hide resolved
After linking https://karlstoney.com/istio-at-scale-sidecar/ 1000 times, probably a good idea to make it first class (thanks Karl!!)
content/en/docs/ops/configuration/mesh/configuration-scoping/index.md
Outdated
Show resolved
Hide resolved
content/en/docs/ops/configuration/mesh/configuration-scoping/index.md
Outdated
Show resolved
Hide resolved
content/en/docs/ops/deployment/performance-and-scalability/index.md
Outdated
Show resolved
Hide resolved
…ndex.md Co-authored-by: Frank Budinsky <frankb@ca.ibm.com>
Co-authored-by: Frank Budinsky <frankb@ca.ibm.com> Co-authored-by: Craig Box <craig.box@gmail.com>
@dhawton can you take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About time!
content/en/docs/ops/configuration/mesh/configuration-scoping/index.md
Outdated
Show resolved
Hide resolved
content/en/docs/ops/configuration/mesh/configuration-scoping/index.md
Outdated
Show resolved
Hide resolved
content/en/docs/ops/configuration/mesh/configuration-scoping/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Faseela K <k.faseela@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM will let @kfaseela take another look
* Add operational document on configuration scoping After linking https://karlstoney.com/istio-at-scale-sidecar/ 1000 times, probably a good idea to make it first class (thanks Karl!!) * Update content/en/docs/ops/configuration/mesh/configuration-scoping/index.md Co-authored-by: Frank Budinsky <frankb@ca.ibm.com> * Apply suggestions from code review Co-authored-by: Frank Budinsky <frankb@ca.ibm.com> Co-authored-by: Craig Box <craig.box@gmail.com> * Apply suggestions from code review Co-authored-by: Faseela K <k.faseela@gmail.com> --------- Co-authored-by: Craig Box <craig.box@gmail.com> Co-authored-by: Frank Budinsky <frankb@ca.ibm.com> Co-authored-by: Faseela K <k.faseela@gmail.com>
After linking https://karlstoney.com/istio-at-scale-sidecar/ 1000 times, probably a good idea to make it first class (thanks Karl!!)