Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operational document on configuration scoping #14702

Merged
merged 4 commits into from May 9, 2024

Conversation

howardjohn
Copy link
Member

After linking https://karlstoney.com/istio-at-scale-sidecar/ 1000 times, probably a good idea to make it first class (thanks Karl!!)

@howardjohn howardjohn requested a review from a team as a code owner March 7, 2024 19:11
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 7, 2024

When [namespace isolation](/docs/reference/config/networking/sidecar/) is enabled,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not strictly related ,but these numbers are basically made up junk from Istio 1.0. Its misleading to users to claim such a simple mapping of services => CPU.

Copy link
Member

@dhawton dhawton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit for consistency, otherwise LGTM

After linking https://karlstoney.com/istio-at-scale-sidecar/ 1000 times,
probably a good idea to make it first class (thanks Karl!!)
craigbox and others added 2 commits March 13, 2024 11:37
…ndex.md

Co-authored-by: Frank Budinsky <frankb@ca.ibm.com>
Co-authored-by: Frank Budinsky <frankb@ca.ibm.com>
Co-authored-by: Craig Box <craig.box@gmail.com>
@howardjohn
Copy link
Member Author

@dhawton can you take a look

Copy link
Contributor

@keithmattix keithmattix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About time!

Co-authored-by: Faseela K <k.faseela@gmail.com>
Copy link
Member

@dhawton dhawton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM will let @kfaseela take another look

@istio-testing istio-testing merged commit de9edba into istio:master May 9, 2024
6 checks passed
costinm pushed a commit to costinm/istio.github.io that referenced this pull request May 9, 2024
* Add operational document on configuration scoping

After linking https://karlstoney.com/istio-at-scale-sidecar/ 1000 times,
probably a good idea to make it first class (thanks Karl!!)

* Update content/en/docs/ops/configuration/mesh/configuration-scoping/index.md

Co-authored-by: Frank Budinsky <frankb@ca.ibm.com>

* Apply suggestions from code review

Co-authored-by: Frank Budinsky <frankb@ca.ibm.com>
Co-authored-by: Craig Box <craig.box@gmail.com>

* Apply suggestions from code review

Co-authored-by: Faseela K <k.faseela@gmail.com>

---------

Co-authored-by: Craig Box <craig.box@gmail.com>
Co-authored-by: Frank Budinsky <frankb@ca.ibm.com>
Co-authored-by: Faseela K <k.faseela@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants