New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct Istio Upgrade version step message #13747
base: master
Are you sure you want to change the base?
Conversation
The existing message implies that upgrading two minor versions is supported, and indeed this has historically been the case, at least anecdotally. The Istio 1.17 control plane however, is not compatible with Istio 1.15 proxies, breaking that soft rule. That should be reflected here, to prevent users from incorrectly jumping multiple minor versions.
|
😊 Welcome! This is either your first contribution to the Istio documentation repo, or
Thanks for contributing! Courtesy of your friendly welcome wagon. |
Hi @CathalC2011. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Would you point to where this is discussed. Is this maybe related to this istio/istio#43785? I believe there was an issue upgrading to 1.17.0 and 1.17.1 but it was fixed in 1.17.2. |
@@ -7,5 +7,5 @@ test: n/a | |||
--- | |||
|
|||
{{< warning >}} | |||
Upgrading across more than two minor versions (e.g., `1.6.x` to `1.9.x`) in one step is not officially tested or recommended. | |||
Upgrading across more than one minor version (e.g., `1.15.x` to `1.17.x`) in one step is not officially tested or recommended. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading across more than one minor version (e.g., `1.15.x` to `1.17.x`) in one step is not officially tested or recommended. | |
Upgrading across more than two minor version (e.g., `1.15.x` to `1.17.x`) in one step is not officially tested or recommended. Upgrades that skip a minor version should only be done when using [Canary Upgrades](https://istio.io/latest/docs/setup/upgrade/canary/). |
Per John's guidance but still clarify the statement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 should be supported for canary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do test some upgrade testing across two versions although I need to verify what it's doing: https://github.com/istio/istio/tree/master/tests/integration/helm/upgrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we say - Upgrading across more than two minor version (e.g., 1.15.x
to 1.17.x
) in one step is not officially tested or recommended for in place upgrade.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally would like to specifically call out Canary Upgrades and link to doc to help guide toward a set procedure that is better practice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saying "Upgrading across" implies skipping a version, and the original line read "Upgrading across two minor versions (e.g. 1.6 to 1.9)".
I think we need to clarify the statement a little further.
Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
The existing message implies that upgrading two minor versions is supported, and indeed this has historically been the case, at least anecdotally.
The Istio 1.17 control plane however, is not compatible with Istio 1.15 proxies, breaking that soft rule. That should be reflected here, to prevent users from incorrectly jumping multiple minor versions.