Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advance notice of Istio deprecating Opencensus #13715

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

lei-tang
Copy link
Contributor

Please provide a description for what this PR is for.
Advance notice of Istio deprecating Opencensus.

And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.

  • Ambient
  • [ X] Docs
  • Installation
  • Networking
  • Performance and Scalability
  • [X ] Extensions and Telemetry
  • Security
  • Test and Release
  • [X ] User Experience
  • Developer Infrastructure

@lei-tang lei-tang requested a review from a team as a code owner August 10, 2023 18:01
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 10, 2023
@istio-policy-bot
Copy link

😊 Welcome! This is either your first contribution to the Istio documentation repo, or
it's been awhile since you've been here. A few things you should know:

  • You can learn about how we write and maintain documentation, about our style guidelines,
    and about all the available web site features by visiting Contributing to the Docs.

  • In the next few minutes, an automatic preview of your change will be
    built as a full copy of the istio.io website. You can find this preview by clicking on
    the Details link next to the deploy/netlify entry in the Status section of this
    page.

  • We care about quality, so we've put in place a number of checks to ensure our documentation
    is top notch. We do spell checking, we sanitize the markdown, we ensure all hyperlinks point
    to valid location, and more. If your PR doesn't pass one of these checks, you'll see a red X in the
    status section of the page. Click on the Details link to get a list of the problems with your PR.
    Fix those problems and push an update to your PR. This will automatically rerun the tests and
    hopefully this time everything will be perfect.

  • Once your changes are accepted and merged into the repository, they will initially show up
    on https://preliminary.istio.io. The changes will be published to https://istio.io
    the next time we do a major release (which typically happens every 3 months or so).

Thanks for contributing!

Courtesy of your friendly welcome wagon.

Copy link
Contributor

@kyessenov kyessenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for publishing this!


OpenCensus has [sunsetted](https://opentelemetry.io/blog/2023/sunsetting-opencensus) on July 31st, 2023.

The OpenCensus sunsetting will impact Istio's usage of OpenCensus in tracing, logging, and metrics. Istio
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you expand on where it's used exactly? Is it just Stackdriver and OpenCensus providers? Do we export zipkin with OpenCensus?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just Stackdriver and OpenCensus providers. We do not export zipkin with OpenCensus.

@istio istio deleted a comment from istio-testing Aug 10, 2023
Comment on lines 10 to 11
The OpenCensus sunset will impact Istio's usage of OpenCensus in tracing, logging, and metrics. Istio
plans to use OpenTelemetry exporters with the OpenTelemetry collector to provide matching telemetry capabilities.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is extremely confusing to me.... maybe I am missing something

First, 99.99% of Istio users do not use OpenCensus at all. This document needs to be more clear about who is impacted.

AFAIK only users who configure https://istio.io/latest/docs/reference/config/istio.mesh.v1alpha1/#MeshConfig-ExtensionProvider-OpenCensusAgentTracingProvider are impacted. This is also only tracing, not logging/metrics.

its also not clear why otel collector is recommended. That is not our problem - users should use https://istio.io/latest/docs/reference/config/istio.mesh.v1alpha1/#MeshConfig-ExtensionProvider-OpenTelemetryTracingProvider, but whether they point to a collector or other OTLP receiver is their problem

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stackdriver uses OpenCensus too. We should say clearly which API fields are going to be removed and put deprecations there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may need to be designed. If an equivalent C++ SDK or an OTLP endpoint is used, the deprecation may be transparent to users.

The OpenCensus sunset will impact Istio's usage of OpenCensus in tracing, logging, and metrics. Istio
plans to use OpenTelemetry exporters with the OpenTelemetry collector to provide matching telemetry capabilities.

This is an advance notice of Istio deprecating OpenCensus, which is tentatively scheduled to Oct. 10, 2024.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we really going to keep it for 1 year? Seems longer than I expected.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deprecation policy of cloud vendors often mandates at least 12-month advance notice.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok but that doesn't really have barring in what Istio does.

Comment on lines 14 to 15
At that point, Istio will stop supporting OpenCensus. We encourage you to start planning the transition to
OpenTelemetry in Istio. If you don't plan this, you may put yourself in the position of having to do a major upgrade in a short timeframe.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted, is OpenTelemetry the only option. Then this makes sense. Otherwise, we should be telling them to move from OpenCensus.

Suggested change
At that point, Istio will stop supporting OpenCensus. We encourage you to start planning the transition to
OpenTelemetry in Istio. If you don't plan this, you may put yourself in the position of having to do a major upgrade in a short timeframe.
At that point, Istio will stop supporting OpenCensus. We encourage you to start planning a transition to
OpenTelemetry in Istio. If you don't plan ahead, you may put yourself in the position of having to do a major upgrade in a short timeframe.

Copy link
Contributor Author

@lei-tang lei-tang Aug 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the wording to be transition away from opencensus.

The sunset of OpenCensus will impact Istio's usage of OpenCensus in tracing, logging, and metrics. Istio
plans to use OpenTelemetry exporters with the OpenTelemetry collector to provide matching telemetry capabilities.

This is an advance notice of Istio deprecating OpenCensus, tentatively scheduled for Oct. 10, 2024.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This date has sailed past. Is this still relevant, @lei-tang ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's relevant. @lei-tang did you want to remove opencensus API (not stackdriver) for Istio 1.20?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Istio 1.20 release candidate is out on 11-2-2023 https://gcsweb.istio.io/gcs/istio-release/releases/1.20.0-rc.0/, I think the work to remove opencensus may take more time to complete (such as Istio 1.21 or 1.22). Do we have any volunteers to work on removing opencensus?

@kyessenov
Copy link
Contributor

I think we did a disservice by not publishing this earlier... Istio project cannot maintain OpenCensus upstream dependency so we'll be forced to remove it in a non-graceful way.

plans to use OpenTelemetry exporters with the OpenTelemetry collector to provide matching telemetry capabilities.

This is an advance notice of Istio deprecating OpenCensus, tentatively scheduled for Oct. 10, 2024.
At that point, Istio will stop supporting OpenCensus. We encourage you to start planning a transition away
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link to what users should use instead (presumably, an OpenTelemetry doc)


OpenCensus was [sunset](https://opentelemetry.io/blog/2023/sunsetting-opencensus) on July 31st, 2023.

The sunset of OpenCensus will impact Istio's usage of OpenCensus in tracing, logging, and metrics. Istio
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link to the specific API fields in Istio that will stop working.

OpenCensus was [sunset](https://opentelemetry.io/blog/2023/sunsetting-opencensus) on July 31st, 2023.

The sunset of OpenCensus will impact Istio's usage of OpenCensus in tracing, logging, and metrics. Istio
plans to use OpenTelemetry exporters with the OpenTelemetry collector to provide matching telemetry capabilities.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this. There is no consensus in Istio that OTEL collectors will be used in Istio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/extensions and telemetry area/user experience kind/docs size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants