46223 Add missing step to apply destination rules after running virtual services

[bedla]

Hi,
This is PR for #13664 ... see detials there.
Thx
Ivos

[istio-policy-bot]

😊 Welcome! This is either your first contribution to the Istio documentation repo, or
it's been awhile since you've been here. A few things you should know:

• You can learn about how we write and maintain documentation, about our style guidelines,
  and about all the available web site features by visiting Contributing to the Docs.

• In the next few minutes, an automatic preview of your change will be
  built as a full copy of the istio.io website. You can find this preview by clicking on
  the Details link next to the deploy/netlify entry in the Status section of this
  page.

• We care about quality, so we've put in place a number of checks to ensure our documentation
  is top notch. We do spell checking, we sanitize the markdown, we ensure all hyperlinks point
  to valid location, and more. If your PR doesn't pass one of these checks, you'll see a red X in the
  status section of the page. Click on the Details link to get a list of the problems with your PR.
  Fix those problems and push an update to your PR. This will automatically rerun the tests and
  hopefully this time everything will be perfect.

• Once your changes are accepted and merged into the repository, they will initially show up
  on https://preliminary.istio.io. The changes will be published to https://istio.io
  the next time we do a major release (which typically happens every 3 months or so).

Thanks for contributing!

Courtesy of your friendly welcome wagon.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: bedla / name: Ivo Šmíd (00e7d9c)

[istio-testing]

Hi @bedla. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[frankbu]

This isn't needed because the warning on line 46 tells the user to make sure it's already done.

If you haven't already, follow the instructions in [define the service versions](/docs/examples/bookinfo/#define-the-service-versions).

[bedla]

ahh, I see. It is kind of hidden.

I executed command from section https://istio.io/latest/docs/setup/getting-started/#bookinfo

And did not clicked to link (because it looks like that it is not necessary) that goes to https://istio.io/latest/docs/examples/bookinfo/ ... let me update the text, to make it more explicit.

[bedla]

I have force pushed changed, what do you think?

[frankbu]

I don't think we want to change the getting started page to tell users to go to another document to do things. The getting started doc is supposed to be a simple, self contained, set of instructions to make it easy for users to start looking at Istio.

I see why the current request-routing instructions are a little confusing (hidden). My suggestion would be to remove the warning on line 46 and put the warning under each tab (Istio APIs and Gateway API) instead.

Then you can change the wording under the Istio APIs tab to make it clear that it's asking you to create the destination rules:

If you haven’t already applied destination rules, follow the instructions in [define the service versions](/docs/examples/bookinfo/#define-the-service-versions).

[Arhell]

/ok-to-test

[craigbox]

Please update the PR with Frank's suggestions.
(I definitely think the problem is on the request-routing page, not the getting started page.)