Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ocp_setup.sh to set common setup for OCP clusters #1032

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fjglira
Copy link

@fjglira fjglira commented Apr 25, 2024

Adding ocp_setup.sh similar to what kind_provisioner.sh does. The idea is to have common setup in this file to be used later to run istio/istio and istio-ecosystem/sail-operator integration test over OCP clusters using the proper script on each repo.

This script set the internal registry of the OCP cluster to be able to pull and push the images that are going to be tested on each PR, also create the proper RoleBindings to be able to pull those images later inside the cluster

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Apr 25, 2024
@istio-policy-bot
Copy link

😊 Welcome @fjglira! This is either your first contribution to the Istio common-files repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing
Copy link
Contributor

Hi @fjglira. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 25, 2024
Signed-off-by: frherrer <frherrer@redhat.com>
@fjglira fjglira marked this pull request as ready for review April 25, 2024 10:31
@fjglira fjglira requested a review from a team as a code owner April 25, 2024 10:31
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Apr 25, 2024
Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain a bit more? The T&R stance currently is to test istio organization exclusively on kind, so we would want to get more buy-in before making any alternative decisions.

In the meantime, since that leaves only istio-ecosystem/sail-operator using OCP it probably would be more expedient to check this into sail-operator directly?

@dgn
Copy link

dgn commented Apr 25, 2024

Can you explain a bit more? The T&R stance currently is to test istio organization exclusively on kind, so we would want to get more buy-in before making any alternative decisions.

In the meantime, since that leaves only istio-ecosystem/sail-operator using OCP it probably would be more expedient to check this into sail-operator directly?

For some context, we forked the istio repository into our org to run tests against OCP there (because of the limitations of our OpenShift prow needing admin access to the org). We basically pull in the latest commits regularly, spin up a cluster and run the tests. So we thought that maybe contributing the necessary scripts upstream would make sense - we would be maintaining them, otherwise our CI jobs fail. And if others are interested to locally test against OCP, they could do it straight out of the istio repo. But if you think it should be located elsewhere, we can keep it in the fork for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
5 participants