update table size docs #3175
Merged
update table size docs #3175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
ramaraochavali
added
the
release-notes-none
|
😊 Welcome @ramaraochavali! This is either your first contribution to the Istio api repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
istio-testing
added
the
size/XS
ericvn
reviewed
Apr 30, 2024
networking/v1/destination_rule.proto
Outdated
| @@ -420,6 +420,8 @@ message LoadBalancerSettings { | |||
| // The table size for Maglev hashing. This helps in controlling the | |||
| // disruption when the backend hosts change. | |||
| // Increasing the table size reduces the amount of disruption. | |||
| // The table size must be prime number limited to 5000011. | |||
There was a problem hiding this comment.
Should this maybe be:
Suggested change
| // The table size must be prime number limited to 5000011. | |
| // The table size must be prime number less than 5000011. |
There was a problem hiding this comment.
Yes. As per envoy docs it is
howardjohn
approved these changes
Apr 30, 2024
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
ericvn
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.