cors: add unmatched_preflights #3171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
size/S
zirain
added
release-notes-none
hzxuzhonghu
reviewed
Apr 23, 2024
istio-testing
added
the
size/S
zirain
changed the title
hzxuzhonghu
reviewed
Apr 30, 2024
istio-testing
added
size/M
zirain
changed the title
howardjohn
reviewed
May 9, 2024
networking/v1/virtual_service.proto
Outdated
| enum UnmatchedPreflights { | ||
| // Preflight requests not matching the configured allowed origin | ||
| // will be forwarded to the upstream. | ||
| FORWARD = 0; |
There was a problem hiding this comment.
I would set 0 to UNSPECIFIED. If we do forward = 0, we can never change our mind in the future and make 'ignore' the default. Even if we don't plan to now, its best to be precise
howardjohn
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: envoyproxy/envoy#33051
Introduce
forward_not_matching_preflightsallow to return local reply when preflight origin does not match allowed origins.API: #3171