Update mesh config to not import k8s libraries #3154
Merged
+1,384
−1,085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardjohn
added
the
release-notes-none
|
Skipping CI for Draft Pull Request. |
istio-testing
added
do-not-merge/work-in-progress
|
What's the motivation for this? |
|
The motivation here is to not require API importers to depend on bloated k8s libraries. In particular, pilot-agent |
howardjohn
force-pushed
the
mesh/drop-metav1-req
branch
from
c23c2e9
to
4f33843
Compare
istio-policy-bot
added
the
lifecycle/stale
istio-testing
removed
the
do-not-merge/work-in-progress
jwendell
approved these changes
May 14, 2024
istio-policy-bot
removed
lifecycle/stale
kyessenov
approved these changes
May 16, 2024
hzxuzhonghu
approved these changes
May 17, 2024
ericvn
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impl in istio/istio#51041. Drops 11% of the agent binary size
--
This PR decouples our APIs from k8s.io, which are super bloated. This gives the same user facing interface. Mesh config is not a proto that is sent over the wire.