Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add from_cookies filed for JWTRule #2500

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add from_cookies filed for JWTRule #2500

wants to merge 1 commit into from
+87 −15

Conversation

kebe7jun
Copy link
Member

For #2499

@kebe7jun kebe7jun requested a review from a team as a code owner October 10, 2022 05:14
@istio-policy-bot
Copy link

😊 Welcome @kebe7jun! This is either your first contribution to the Istio api repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 10, 2022
@kebe7jun kebe7jun added area/security and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 10, 2022
@istio-testing
Copy link
Collaborator

@kebe7jun: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
release-notes_api 7cbffcd link false /test release-notes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kebe7jun
Copy link
Member Author

@istio/technical-oversight-committee Would you mind taking a look at this PR?

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Nov 18, 2022
@istio-testing
Copy link
Collaborator

@kebe7jun: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/security needs-rebase Indicates a PR needs to be rebased before being merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kebe7jun @istio-policy-bot @istio-testing