New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add an field to avoid interpreting the hosts on dr and vs #2231
Conversation
Hi @Patrick0308. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
is_fully_host
on dr and vs
/ok-to-test |
@ericvn @howardjohn @hzxuzhonghu. Hey guys, I want to know what's your opinion about this. |
@Patrick0308: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What is the purpose of this change? I get that host interpretation can be complex - see DNS - but do we have a reason not to follow the DNS spec for host strings? |
@Patrick0308: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@louiscryan Pls see istio/istio#36864. When the service host is the k8s service host, the short name interpreted to FQDN. It's ok. However, if the host is for service entry, the interpretation is unwarranted. |
🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2022-02-11. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions. Created by the issue and PR lifecycle manager. |
See istio/istio#36864
Adding an option on virtual service's spec. if the field is true, istio will be not resolve short name to FQDN. Denstation rule is the same.